-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional options to compress and expand #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
- Coverage 99.32% 98.35% -0.98%
==========================================
Files 9 10 +1
Lines 593 729 +136
Branches 127 170 +43
==========================================
+ Hits 589 717 +128
- Misses 3 10 +7
- Partials 1 2 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cthoyt
added a commit
that referenced
this pull request
Oct 13, 2023
As a follow-up to #79, this PR adds options for strict and passthrough to standardization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63
This PR adds the
strict
andpassthrough
option, since many people typically implement these operations themselves. It also adds more specific examples to the "getting started" tutorial for these.This means for @shawntanzk's use case, you can add
passthrough=True
when callingGives
But when adding
passthrough=True
inconverter.pd_compress(df, column="uri", target_column="curie", passthrough=True)
, gives: