Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize prefix map export implementation #972

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Externalize prefix map export implementation #972

merged 5 commits into from
Nov 2, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Nov 1, 2023

Writing EPMs, JSON-LD, and SHACL are now part of the curies package. This PR externalizes them.

It has a small drawback that for SHACL, it now uses the canonical prefix's pattern when that differs from the specific one. To give an example, the kegg prefix has a generic pattern that fits all of its children. The kegg.drug is a subspace of kegg and has a specific pattern. This is no longer captured.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/bioregistry/record_accumulator.py 91.13% <100.00%> (+0.05%) ⬆️
src/bioregistry/resource_manager.py 75.23% <ø> (ø)
src/bioregistry/version.py 68.42% <100.00%> (ø)
src/bioregistry/export/prefix_maps.py 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

@cthoyt cthoyt merged commit 1f12bae into main Nov 2, 2023
@cthoyt cthoyt deleted the update-exports branch November 2, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant