chore: extract noPackagePrivateImports rule
#4651
Merged
+366
−387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
CodSpeed Performance ReportMerging #4651 will not alter performanceComparing Summary
|
ematipico
approved these changes
Nov 28, 2024
|
|
||
| # The rule `useImportRestrictions` has been renamed to `noPackagePrivateImports` | ||
|
|
||
| To avoid confusion with `noRestrictedImports`, `useImportRestrictions` has been |
There was a problem hiding this comment.
Since noRestrictedImports is a nursery rule, we can make this a patch, because nursery rules don't follow semver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously I moved the
useImportRestrictionsrule intonoRestrictedImports, because they were too similarly named. But someone rightly pointed out they should've remained separate rules, so I've extracted the rule again and renamed it.Test Plan
CI should remain green.