Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analyzer): suppression comment fails with inner comments in functions #4643

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fireairforce
Copy link
Member

@fireairforce fireairforce commented Nov 26, 2024

Summary

closes: #4519

Test Plan

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Nov 26, 2024
Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #4643 will degrade performances by 6.57%

Comparing fireairforce:fix-4519 (cfe66c3) with main (4848994)

Summary

❌ 1 regressions
✅ 96 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fireairforce:fix-4519 Change
react.production.min_3378072959512366797.js[uncached] 2.1 ms 2.2 ms -6.57%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 Suppression comment fails with inner comments in functions
1 participant