feat(lint): add rule noJsxPropsBind #4639
Draft
+218
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
dyc3
requested changes
Nov 26, 2024
| /// | ||
| pub NoBind { | ||
| version: "next", | ||
| name: "noBind", |
There was a problem hiding this comment.
I feel like we can come up with a better name than noBind. At the very least, it should mention "Jsx" since this rule should only apply to Jsx.
There was a problem hiding this comment.
Oh, I see😅.
However, I've noticed that some existing JSX rules include "jsx" in their names while others do not. Maybe need to standardize "Jsx" naming convention.
Comment on lines
29
to
34
| pub NoBind { | ||
| version: "next", | ||
| name: "noBind", | ||
| language: "js", | ||
| recommended: false, | ||
| } |
There was a problem hiding this comment.
This doesn't have a rule source
Co-authored-by: Carson McManus <[email protected]>
thecode00
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement react/jsx-no-bind
Test Plan