fix(useCollapsedIf): ignore if with else clause #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
Conaclos
force-pushed
the
conaclos/useCollapsedIf-ignore-if-with-else
branch
from
7fbd9d6 to
126946f
Compare
ematipico
approved these changes
Oct 17, 2024
CodSpeed Performance ReportMerging #4322 will not alter performanceComparing Summary
|
|
Thank you for fixing my mistakes @Conaclos 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While I was testing the last version of Biome (#4320), I noted that
useCollapsedIfdoesn't ignoreifwith anelseclause.This PR fixes this bug.
Also, I improved the code fix by adding spaces around the
&&operator.Test Plan