Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql_analyze): add suppression action for the GraphQL linter #4312

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

vohoanglong0107
Copy link
Contributor

@vohoanglong0107 vohoanglong0107 commented Oct 16, 2024

Summary

Add a suppression action for the GraphQL linter, as it is required for the analyzer to be deemed stable.
Close #4148

Test Plan

Added new tests that show how the the linter emits suppression action.

Notes

I can rebase this onto #4306 if we don't need to release this soon.

Copy link

codspeed-hq bot commented Oct 16, 2024

CodSpeed Performance Report

Merging #4312 will not alter performance

Comparing vohoanglong0107:graphql-supress-action (2313266) with main (8931d43)

Summary

✅ 101 untouched benchmarks

@vohoanglong0107 vohoanglong0107 requested a review from a team October 16, 2024 22:48
@vohoanglong0107 vohoanglong0107 marked this pull request as ready for review October 16, 2024 22:48
@ematipico ematipico requested a review from a team October 17, 2024 10:09
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a start. Would you mind updating the changelog?

@ematipico ematipico added the S-Merge for next minor Status: the PR should be merged in the next minor label Oct 17, 2024
@vohoanglong0107
Copy link
Contributor Author

Done!

@github-actions github-actions bot added the A-Changelog Area: changelog label Oct 17, 2024
@ematipico
Copy link
Member

Thank you. We'll merge once we are finished with bug fixes

@ematipico ematipico merged commit 1c60340 into biomejs:main Oct 18, 2024
11 checks passed
@vohoanglong0107 vohoanglong0107 deleted the graphql-supress-action branch October 19, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter S-Merge for next minor Status: the PR should be merged in the next minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Implement suppression action for GraphQL analyzer
2 participants