Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useConsistentMemberAccessibility): ignore #private class members #4292

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix #4276

Test Plan

I updated the snapshots.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Oct 14, 2024
@Conaclos Conaclos force-pushed the conaclos/useConsistentMemberAccessibility-4276 branch from 355195e to 05c5227 Compare October 14, 2024 11:03
Copy link

codspeed-hq bot commented Oct 14, 2024

CodSpeed Performance Report

Merging #4292 will improve performances by 8.22%

Comparing conaclos/useConsistentMemberAccessibility-4276 (05c5227) with main (88405b7)

Summary

⚡ 2 improvements
✅ 103 untouched benchmarks

Benchmarks breakdown

Benchmark main conaclos/useConsistentMemberAccessibility-4276 Change
react.production.min_3378072959512366797.js[uncached] 2.3 ms 2.1 ms +6.13%
db_17847247775464589309.json[cached] 13.8 ms 12.7 ms +8.22%

@Conaclos Conaclos merged commit d254b97 into main Oct 14, 2024
11 checks passed
@Conaclos Conaclos deleted the conaclos/useConsistentMemberAccessibility-4276 branch October 14, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💅 Private class properties (#) cause errors when using accessibility explicit
1 participant