Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): add variable assignment tracking to noDocumentCookie rule #4255

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

tunamaguro
Copy link
Contributor

Summary

This is followup PR to #4204 .

This PR extends the implementation of noDocumentCookie by adding support for tracking assignments to variables.

Now, the following code will be supported.

const doc = document;
doc.cookie = "foo = bar";

Test Plan

  • Added tests to verify the handling of variable assignments.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Oct 11, 2024
Copy link

codspeed-hq bot commented Oct 11, 2024

CodSpeed Performance Report

Merging #4255 will not alter performance

Comparing tunamaguro:track-document-assign (c1debf8) with main (fbe5552)

Summary

✅ 105 untouched benchmarks

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @tunamaguro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants