fix(useButtonType): don't report dynamically created button with valid type #4074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #4072
This solves two bugs:
find_prop_by_name
utility only returned quoted property.For instance
{ "type": foo }
was reported, while{ type: foo }
was not reported."type"
property set with any string value, including valid ones.I have to admit that I was a bit surprised that our JSX rules handle dynamic code such as
React.createElement
. I wonder if we should restrict our rules to JSX and ignore dynamic creation completely.I took the opportunity of refactoring a bit the flow to make it more readable.
Test Plan
I added a test