Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): support direct const assertions in useExplicitFunctionReturnType rule #4027

Merged

Conversation

kaykdm
Copy link
Contributor

@kaykdm kaykdm commented Sep 21, 2024

Summary

Related issue: #2017

Implemented support for direct const assertions in arrow functions in this rule. (allowDirectConstAssertionInArrowFunctions in typescript-eslint/explicit-function-return-type)

Test Plan

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Sep 21, 2024
@kaykdm kaykdm changed the title Support direct const assertions in useExplicitFunctionReturnType rule feat(linter): Support direct const assertions in useExplicitFunctionReturnType rule Sep 21, 2024
@kaykdm kaykdm changed the title feat(linter): Support direct const assertions in useExplicitFunctionReturnType rule feat(linter): support direct const assertions in useExplicitFunctionReturnType rule Sep 21, 2024
Copy link

codspeed-hq bot commented Sep 21, 2024

CodSpeed Performance Report

Merging #4027 will not alter performance

Comparing kaykdm:support-direct-const-assertions-in-arrow-function (55c3072) with main (29266a0)

Summary

✅ 107 untouched benchmarks

@Conaclos Conaclos merged commit f6e6cb6 into biomejs:main Sep 21, 2024
12 checks passed
@kaykdm kaykdm deleted the support-direct-const-assertions-in-arrow-function branch September 22, 2024 01:19
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants