Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formatter/html): add line break at the end of files #4010

Merged

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 20, 2024

Summary

Very simple. Prettier always ends files with an extra newline, and so do we with other files.

Test Plan

@github-actions github-actions bot added A-Formatter Area: formatter L-HTML Language: HTML labels Sep 20, 2024
Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #4010 will degrade performances by 21.68%

Comparing 09-18-feat_formatter_html_add_line_break_at_the_end_of_files (2afb989) with main (d137533)

Summary

❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 09-18-feat_formatter_html_add_line_break_at_the_end_of_files Change
big5-added_15586211152145260264.json[uncached] 564.1 µs 720.2 µs -21.68%

@dyc3 dyc3 force-pushed the 09-18-feat_formatter_html_add_line_break_at_the_end_of_files branch from 323c512 to 2afb989 Compare September 20, 2024 11:54
@dyc3 dyc3 merged commit 0254098 into main Sep 20, 2024
14 of 15 checks passed
@dyc3 dyc3 deleted the 09-18-feat_formatter_html_add_line_break_at_the_end_of_files branch September 20, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter L-HTML Language: HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant