-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): implement noOctalEscape #3986
Conversation
457e685
to
5157d84
Compare
CodSpeed Performance ReportMerging #3986 will degrade performances by 6.16%Comparing Summary
Benchmarks breakdown
|
5157d84
to
880e6e8
Compare
crates/biome_js_analyze/tests/specs/nursery/noOctalEscape/valid.js
Outdated
Show resolved
Hide resolved
880e6e8
to
8958184
Compare
9df2541
to
905b346
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could improve the diagnostic by reporting only the octal escape sequence. This is a possible future improvement.
Summary
closes: #3929
Test Plan