-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser/html): lex and parse unquoted attribute values #3951
feat(parser/html): lex and parse unquoted attribute values #3951
Conversation
CodSpeed Performance ReportMerging #3951 will degrade performances by 6.44%Comparing Summary
Benchmarks breakdown
|
f991283
to
fb69e6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to me, however we should:
- Add more test cases, for example, cases where the attribute value has spaces (
\n
,\t
) and<
/>
, because they are part of the new logic. - Add an invalid test case that covers the new error you added
fb69e6c
to
5e73499
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, there's one case to cover and we can merge it
crates/biome_html_parser/tests/html_specs/ok/attributes/attributes-unquoted.html.snap
Show resolved
Hide resolved
5e73499
to
4b03d2f
Compare
Summary
This PR lets the HTML parser correctly lex and parse unquoted attribute values.
Test Plan
Added a test. See also: https://html.spec.whatwg.org/#attributes-2