Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linter): rename useConsistentGridAreas to noInvalidGridAreas #3809

Merged
merged 2 commits into from
Sep 6, 2024
Merged

chore(linter): rename useConsistentGridAreas to noInvalidGridAreas #3809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32b2ca9
chore: rename useConsistentGridAreas to noInvalidGridAreas
togami2864 Sep 6, 2024
be650ee
chore: just gen-lint
togami2864 Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 74 additions & 74 deletions crates/biome_configuration/src/analyzer/linter/rules.rs
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions crates/biome_css_analyze/src/lint/nursery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ pub mod no_duplicate_selectors_keyframe_block;
pub mod no_empty_block;
pub mod no_important_in_keyframe;
pub mod no_invalid_direction_in_linear_gradient;
pub mod no_invalid_grid_areas;
pub mod no_invalid_position_at_import_rule;
pub mod no_irregular_whitespace;
pub mod no_shorthand_property_overrides;
Expand All @@ -19,7 +20,6 @@ pub mod no_unknown_selector_pseudo_element;
pub mod no_unknown_unit;
pub mod no_unmatchable_anb_selector;
pub mod no_value_at_rule;
pub mod use_consistent_grid_areas;
pub mod use_generic_font_names;

declare_lint_group! {
Expand All @@ -32,6 +32,7 @@ declare_lint_group! {
self :: no_empty_block :: NoEmptyBlock ,
self :: no_important_in_keyframe :: NoImportantInKeyframe ,
self :: no_invalid_direction_in_linear_gradient :: NoInvalidDirectionInLinearGradient ,
self :: no_invalid_grid_areas :: NoInvalidGridAreas ,
self :: no_invalid_position_at_import_rule :: NoInvalidPositionAtImportRule ,
self :: no_irregular_whitespace :: NoIrregularWhitespace ,
self :: no_shorthand_property_overrides :: NoShorthandPropertyOverrides ,
Expand All @@ -43,7 +44,6 @@ declare_lint_group! {
self :: no_unknown_unit :: NoUnknownUnit ,
self :: no_unmatchable_anb_selector :: NoUnmatchableAnbSelector ,
self :: no_value_at_rule :: NoValueAtRule ,
self :: use_consistent_grid_areas :: UseConsistentGridAreas ,
self :: use_generic_font_names :: UseGenericFontNames ,
]
}
Expand Down
6 changes: 3 additions & 3 deletions ...lint/nursery/use_consistent_grid_areas.rs → ...src/lint/nursery/no_invalid_grid_areas.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ declare_lint_rule! {
/// "a a a"; }
/// ```
///
pub UseConsistentGridAreas {
pub NoInvalidGridAreas {
version: "next",
name: "useConsistentGridAreas",
name: "noInvalidGridAreas",
language: "css",
recommended: false,
sources: &[RuleSource::Stylelint("named-grid-areas-no-invalid")],
Expand All @@ -73,7 +73,7 @@ pub struct UseConsistentGridAreasState {
reason: GridAreaValidationError,
}

impl Rule for UseConsistentGridAreas {
impl Rule for NoInvalidGridAreas {
type Query = Ast<CssDeclarationOrRuleList>;
type State = UseConsistentGridAreasState;
type Signals = Option<Self::State>;
Expand Down
3 changes: 2 additions & 1 deletion crates/biome_css_analyze/src/options.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 ...ursery/useConsistentGridAreas/invalid.css → ...cs/nursery/noInvalidGridAreas/invalid.css
View file
Open in desktop
File renamed without changes.
20 changes: 10 additions & 10 deletions ...y/useConsistentGridAreas/invalid.css.snap → ...rsery/noInvalidGridAreas/invalid.css.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ a { grid-template-areas: "a a a"

# Diagnostics
```
invalid.css:1:26 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
invalid.css:1:26 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

! Empty grid areas are not allowed.

Expand All @@ -52,7 +52,7 @@ invalid.css:1:26 lint/nursery/useConsistentGridAreas ━━━━━━━━━
```

```
invalid.css:2:26 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
invalid.css:2:26 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

! Inconsistent cell count in grid areas are not allowed.

Expand All @@ -68,7 +68,7 @@ invalid.css:2:26 lint/nursery/useConsistentGridAreas ━━━━━━━━━
```

```
invalid.css:4:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
invalid.css:4:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

! Empty grid areas are not allowed.

Expand All @@ -87,7 +87,7 @@ invalid.css:4:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━
```

```
invalid.css:6:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
invalid.css:6:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

! Duplicate filled in rectangle are not allowed.

Expand All @@ -106,7 +106,7 @@ invalid.css:6:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━
```

```
invalid.css:11:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
invalid.css:11:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

! Duplicate filled in rectangle are not allowed.

Expand All @@ -125,7 +125,7 @@ invalid.css:11:33 lint/nursery/useConsistentGridAreas ━━━━━━━━
```

```
invalid.css:15:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
invalid.css:15:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

! Duplicate filled in rectangle are not allowed.

Expand All @@ -144,7 +144,7 @@ invalid.css:15:33 lint/nursery/useConsistentGridAreas ━━━━━━━━
```

```
invalid.css:17:35 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
invalid.css:17:35 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

! Duplicate filled in rectangle are not allowed.

Expand All @@ -163,7 +163,7 @@ invalid.css:17:35 lint/nursery/useConsistentGridAreas ━━━━━━━━
```

```
invalid.css:21:35 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
invalid.css:21:35 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

! Inconsistent cell count in grid areas are not allowed.

Expand All @@ -182,7 +182,7 @@ invalid.css:21:35 lint/nursery/useConsistentGridAreas ━━━━━━━━
```

```
invalid.css:24:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
invalid.css:24:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

! Duplicate filled in rectangle are not allowed.

Expand All @@ -201,7 +201,7 @@ invalid.css:24:33 lint/nursery/useConsistentGridAreas ━━━━━━━━
```

```
invalid.css:27:33 lint/nursery/useConsistentGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
invalid.css:27:33 lint/nursery/noInvalidGridAreas ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

! Duplicate filled in rectangle are not allowed.

Expand Down
0 .../nursery/useConsistentGridAreas/valid.css → ...pecs/nursery/noInvalidGridAreas/valid.css
View file
Open in desktop
File renamed without changes.
0 ...ery/useConsistentGridAreas/valid.css.snap → ...nursery/noInvalidGridAreas/valid.css.snap
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion crates/biome_diagnostics_categories/src/categories.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ define_categories! {
"lint/nursery/useBiomeSuppressionComment": "https://biomejs.dev/linter/rules/use-biome-suppression-comment",
"lint/nursery/useConsistentBuiltinInstantiation": "https://biomejs.dev/linter/rules/use-consistent-new-builtin",
"lint/nursery/useConsistentCurlyBraces": "https://biomejs.dev/linter/rules/use-consistent-curly-braces",
"lint/nursery/useConsistentGridAreas": "https://biomejs.dev/linter/rules/use-consistent-grid-areas",
"lint/nursery/noInvalidGridAreas": "https://biomejs.dev/linter/rules/use-consistent-grid-areas",
"lint/nursery/useConsistentMemberAccessibility": "https://biomejs.dev/linter/rules/use-consistent-member-accessibility",
"lint/nursery/useDateNow": "https://biomejs.dev/linter/rules/use-date-now",
"lint/nursery/useDefaultSwitchClause": "https://biomejs.dev/linter/rules/use-default-switch-clause",
Expand Down
10 changes: 5 additions & 5 deletions packages/@biomejs/backend-jsonrpc/src/workspace.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions packages/@biomejs/biome/configuration_schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading