fix: noAriaHiddenonFocusable when using a JSX expression
#3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
anthonyshew
changed the title
noAriaHiddenonFocusable when using a JSX expression.
anthonyshew
commented
Aug 23, 2024
crates/biome_js_analyze/src/lint/a11y/no_aria_hidden_on_focusable.rs
Outdated
Show resolved
Hide resolved
dyc3
previously requested changes
Aug 23, 2024
CodSpeed Performance ReportMerging #3708 will not alter performanceComparing Summary
|
anthonyshew
changed the title
noAriaHiddenonFocusable when using a JSX expression.noAriaHiddenonFocusable when using a JSX expression.
anthonyshew
changed the title
noAriaHiddenonFocusable when using a JSX expression.noAriaHiddenonFocusable when using a JSX expression
anthonyshew
changed the title
noAriaHiddenonFocusable when using a JSX expressionnoAriaHiddenonFocusable when using a JSX expression
ematipico
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Thank you very much for the bug fix. Everything looks good. I would complete the PR with:
- making the code shared, now that there's a use case
- add a changelog line to
CHANGELOG.md
crates/biome_js_analyze/src/lint/a11y/no_aria_hidden_on_focusable.rs
Outdated
Show resolved
Hide resolved
anthonyshew
force-pushed
the
shew/noAriaHiddenOnFocusable-fix
branch
from
e6013fc
to
4a42a59
Compare
1 task
alexandresoro
added a commit
to alexandresoro/ouca
that referenced
this pull request
Sep 13, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | | minor | `1.8.3` -> `1.9.0` | | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | devDependencies | minor | [`1.8.3` -> `1.9.0`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/1.8.3/1.9.0) | --- ### Release Notes <details> <summary>biomejs/biome (@​biomejs/biome)</summary> ### [`v1.9.0`](https://github.com/biomejs/biome/blob/HEAD/CHANGELOG.md#v190-2024-09-12) [Compare Source](biomejs/biome@c28d597...b260d5b) ##### Analyzer - Implement the [semantic model for CSS](biomejs/biome#3546). Contributed by [@​togami2864](https://github.com/togami2864) ##### CLI ##### New features - Add `--graphql-linter-enabled` option, to control whether the linter should be enabled or not for GraphQL files. Contributed by [@​ematipico](https://github.com/ematipico) - New EXPERIMENTAL `search` command. The search command allows you to search a Biome project using [GritQL syntax](https://biomejs.dev/reference/gritql). GritQL is a powerful language that lets you do *structural* searches on your codebase. This means that trivia such as whitespace or even the type of strings quotes used will be ignored in your search query. It also has many features for querying the structure of your code, making it much more elegant for searching code than regular expressions. While we believe this command may already be useful to users in some situations (especially when integrated in the IDE extensions!), we also had an ulterior motive for adding this command: We intend to utilize GritQL for our plugin efforts, and by allowing our users to try it out in a first iteration, we hope to gain insight in the type of queries you want to do, as well as the bugs we need to focus on. For now, the `search` command is explicitly marked as EXPERIMENTAL, since many bugs remain. Keep this in mind when you try it out, and please [let us know](https://github.com/biomejs/biome/issues) your issues! Note: GritQL escapes code snippets using backticks, but most shells interpret backticks as command invocations. To avoid this, it's best to put *single quotes* around your Grit queries. ```shell biome search '`console.log($message)`' # find all `console.log` invocations ``` Contributed by [@​arendjr](https://github.com/arendjr) and [@​BackupMiles](https://github.com/BackupMiles) - The option `--max-diagnostics` now accept a `none` value, which lifts the limit of diagnostics shown. Contributed by [@​ematipico](https://github.com/ematipico) - Add a new reporter `--reporter=gitlab`, that emits diagnostics for using the [GitLab Code Quality report](https://docs.gitlab.com/ee/ci/testing/code_quality.html#implement-a-custom-tool). ```json [ { "description": "Use === instead of ==. == is only allowed when comparing against `null`", "check_name": "lint/suspicious/noDoubleEquals", "fingerprint": "6143155163249580709", "severity": "critical", "location": { "path": "main.ts", "lines": { "begin": 4 } } } ] ``` Contributed by [@​NiclasvanEyk](https://github.com/NiclasvanEyk) - Add new options to the `lsp-proxy` and `start` commands: - `--log-path`: a directory where to store the daemon logs. The commands also accepts the environment variable `BIOME_LOG_PATH`. - `--log-prefix-name`: a prefix that's added to the file name of the logs. It defaults to `server.log`. The commands also accepts the environment variable `BIOME_LOG_PREFIX_NAME`. [@​Contributed](https://github.com/Contributed) by [@​ematipico](https://github.com/ematipico) ##### Enhancements - When a `--reporter` is provided, and it's different from the default one, the value provided by via `--max-diagnostics` is ignored and **the limit is lifted**. Contributed by [@​ematipico](https://github.com/ematipico) - `biome init` now generates a new config file with more options set. This change intends to improve discoverability of the options and to set the more commonly used options to their default values. Contributed by [@​Conaclos](https://github.com/Conaclos) - The `--verbose` flag now reports the list of files that were evaluated, and the list of files that were fixed. The **evaluated** files are the those files that can be handled by Biome, files that are ignored, don't have an extension or have an extension that Biome can't evaluate are excluded by this list. The **fixed** files are those files that were handled by Biome and *changed*. Files that stays the same after the process are excluded from this list. ```shell VERBOSE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ℹ Files processed: - biome/biome.json - biome/packages/@​biomejs/cli-win32-arm64/package.json - biome/packages/tailwindcss-config-analyzer/package.json VERBOSE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ℹ Files fixed: - biome/biome/packages/tailwindcss-config-analyzer/src/generate-tailwind-preset.ts ``` Contributed by [@​ematipico](https://github.com/ematipico) - Allow passing `nursery` to the `--only` and `--skip` filters. The `--only` option allows you to run a given rule or rule group. The `--skip` option allows you to skip the execution of a given group or a given rule. Previously, it was not possible to pass `nursery`. This restriction is now removed, as it may make sense to skip the nursery rules that a project has enabled. Contributed by [@​Conaclos](https://github.com/Conaclos) - The CLI now returns an error code when calling a command in `stdin` mode, and the contents of the files aren't fixed. For example, the following example will result in an error code of `1` because the `lint` command triggers some lint rules: ```shell echo "let x = 1" | biome lint --stdin-file-path=stdin.js ``` Contributed by [@​ematipico](https://github.com/ematipico) ##### Bug fixes - `biome lint --write` now takes `--only` and `--skip` into account ([#​3470](biomejs/biome#3470)). Contributed by [@​Conaclos](https://github.com/Conaclos) - Fix [#​3368](biomejs/biome#3368), now the reporter `github` tracks the diagnostics that belong to formatting and organize imports. Contributed by [@​ematipico](https://github.com/ematipico) - Fix [#​3545](biomejs/biome#3545), display a warning, 'Avoid using unnecessary Fragment,' when a Fragment contains only one child element that is placed on a new line. Contributed by [@​satojin219](https://github.com/satojin219) - Migrating from Prettier or ESLint no longer overwrite the `overrides` field from the configuration ([#​3544](biomejs/biome#3544)). Contributed by [@​Conaclos](https://github.com/Conaclos) - Fix JSX expressions for `noAriaHiddenOnFocusable` ([#​3708](biomejs/biome#3708)). Contributed by [@​anthonyshew](https://github.com/anthonyshew) - Fix edge case for `<canvas>` elements that use `role="img"` ([#​3728](biomejs/biome#3728)). Contributed by [@​anthonyshew](https://github.com/anthonyshew) - Fix [#​3633](biomejs/biome#3633), where diagnostics where incorrectly printed if the code has errors. Contributed by [@​ematipico](https://github.com/ematipico) - Allow `aria-label` on heading to prevent `useHeadingContent` diagnostic ([#​3767](biomejs/biome#3767)). Contributed by [@​anthonyshew](https://github.com/anthonyshew) - Fix edge case [#​3791](biomejs/biome#3791) for rule `noFocusedTests` being used with non-string-like expressions ([#​3793](biomejs/biome#3793)). Contributed by [@​h-a-n-a](https://github.com/h-a-n-a) - Fix optional ARIA properties for `role="separator"` in `useAriaPropsForRole` ([#​3856](biomejs/biome#3856)). Contributed by [@​anthonyshew](https://github.com/anthonyshew) ##### Configuration - Add support for loading configuration from `.editorconfig` files ([#​1724](biomejs/biome#1724)). Configuration supplied in `.editorconfig` will be overridden by the configuration in `biome.json`. Support is disabled by default and can be enabled by adding the following to your formatter configuration in `biome.json`: ```json { "formatter": { "useEditorconfig": true } } ``` Contributed by [@​dyc3](https://github.com/dyc3) - `overrides` from an extended configuration is now merged with the `overrides` of the extension. Given the following shared configuration `biome.shared.json`: ```json5 { "overrides": [ { "include": ["**/*.json"], // ... } ] } ``` and the following configuration: ```json5 { "extends": ["./biome.shared.json"], "overrides": [ { "include": ["**/*.ts"], // ... } ] } ``` Previously, the `overrides` from `biome.shared.json` was overwritten. It is now merged and results in the following configuration: ```json5 { "extends": ["./biome.shared.json"], "overrides": [ { "include": ["**/*.json"], // ... }, { "include": ["**/*.ts"], // ... } ] } ``` Contributed by [@​Conaclos](https://github.com/Conaclos) ##### Editors - Fix [#​3577](biomejs/biome#3577), where the update of the configuration file was resulting in the creation of a new internal project. Contributed by [@​ematipico](https://github.com/ematipico) - Fix [#​3696](biomejs/biome#3696), where `biome.jsonc` was incorrectly parsed with incorrect options. Contributed by [@​ematipico](https://github.com/ematipico) ##### Formatter - The CSS formatter is enabled by default. Which means that you don't need to opt-in anymore using the configuration file `biome.json`: ```diff { - "css": { - "formatter": { - "enabled": true - } - } } ``` Contributed by [@​ematipico](https://github.com/ematipico) - Add parentheses for nullcoalescing in ternaries. This change aligns on [Prettier 3.3.3](https://github.com/prettier/prettier/blob/main/CHANGELOG.md#333). This adds clarity to operator precedence. ```diff - foo ? bar ?? foo : baz; + foo ? (bar ?? foo) : baz; ``` Contributed by [@​Conaclos](https://github.com/Conaclos) - Keep the parentheses around `infer ... extends` declarations in type unions and type intersections ([#​3419](biomejs/biome#3419)). Contributed by [@​Conaclos](https://github.com/Conaclos) - Keep parentheses around a `yield` expression inside a type assertion. Previously, Biome removed parentheses around some expressions that require them inside a type assertion. For example, in the following code, Biome now preserves the parentheses. ```ts function* f() { return <T>(yield 0); } ``` Contributed by [@​Conaclos](https://github.com/Conaclos) - Remove parentheses around expressions that don't need them inside a decorator. Biome now matches Prettier in the following cases: ```diff class { - @​(decorator) + @​decorator method() {} }, class { - @​(decorator()) + @​decorator() method() {} }, class { @​(decorator?.()) method() {} }, ``` Contributed by [@​Conaclos](https://github.com/Conaclos) - Keep parentheses around objects preceded with a `@satisfies` comment. In the following example, parentheses are no longer removed. ```ts export const PROPS = /** @​satisfies {Record<string, string>} */ ({ prop: 0, }); ``` Contributed by [@​Conaclos](https://github.com/Conaclos) ##### Linter ##### Promoted rules New rules are incubated in the nursery group. Once stable, we promote them to a stable group. The following CSS rules are promoted: - [a11y/useGenericFontNames](https://biomejs.dev/linter/rules/use-generic-font-names/) - [correctness/noInvalidDirectionInLinearGradient](https://biomejs.dev/linter/rules/no-invalid-direction-in-linear-gradient/) - [correctness/noInvalidGridAreas](https://biomejs.dev/linter/rules/no-invalid-grid-areas/) - [correctness/noInvalidPositionAtImportRule](https://biomejs.dev/linter/rules/no-invalid-position-at-import-rule/) - [correctness/noUnknownFunction](https://biomejs.dev/linter/rules/no-unknown-function/) - [correctness/noUnknownMediaFeatureName](https://biomejs.dev/linter/rules/no-unknown-media-feature-name/) - [correctness/noUnknownProperty](https://biomejs.dev/linter/rules/no-unknown-property/) - [correctness/noUnknownUnit](https://biomejs.dev/linter/rules/no-unknown-unit/) - [correctness/noUnmatchableAnbSelector](https://biomejs.dev/linter/rules/no-unmatchable-anb-selector/) - [suspicious/noDuplicateAtImportRules](https://biomejs.dev/linter/rules/no-duplicate-at-import-rules/) - [suspicious/noDuplicateFontNames](https://biomejs.dev/linter/rules/no-duplicate-font-names/) - [suspicious/noDuplicateSelectorsKeyframeBlock](https://biomejs.dev/linter/rules/no-duplicate-selectors-keyframe-block/) - [suspicious/noEmptyBlock](https://biomejs.dev/linter/rules/no-empty-block/) - [suspicious/noImportantInKeyframe](https://biomejs.dev/linter/rules/no-important-in-keyframe/) - [suspicious/noShorthandPropertyOverrides](https://biomejs.dev/linter/rules/no-shorthand-property-overrides/) The following JavaScript rules are promoted: - [a11y/noLabelWithoutControl](https://biomejs.dev/linter/rules/no-label-without-control/) - [a11y/useFocusableInteractive](https://biomejs.dev/linter/rules/use-focusable-interactive/) - [a11y/useSemanticElements](https://biomejs.dev/linter/rules/use-semantic-elements/) - [complexity/noUselessStringConcat](https://biomejs.dev/linter/rules/no-useless-string-concat/) - [complexity/noUselessUndefinedInitialization](https://biomejs.dev/linter/rules/no-useless-undefined-initialization/) - [complexity/useDateNow](https://biomejs.dev/linter/rules/use-date-now/) - [correctness/noUndeclaredDependencies](https://biomejs.dev/linter/rules/no-undeclared-dependencies/) - [correctness/noInvalidBuiltinInstantiation](https://biomejs.dev/linter/rules/no-invalid-builtin-instantiation/) - [correctness/noUnusedFunctionParameters](https://biomejs.dev/linter/rules/no-unused-function-parameters/) - [correctness/useImportExtensions](https://biomejs.dev/linter/rules/use-import-extensions/) - [performance/useTopLevelRegex](https://biomejs.dev/linter/rules/use-top-level-regex/) - [style/noDoneCallback](https://biomejs.dev/linter/rules/no-done-callback/) - [style/noYodaExpression](https://biomejs.dev/linter/rules/no-yoda-expression/) - [style/useConsistentBuiltinInstantiation](https://biomejs.dev/linter/rules/use-consistent-builtin-instantiation/) - [style/useDefaultSwitchClause](https://biomejs.dev/linter/rules/use-default-switch-clause/) - [style/useExplicitLengthCheck](https://biomejs.dev/linter/rules/use-explicit-length-check/) - [style/useThrowNewError](https://biomejs.dev/linter/rules/use-throw-new-error/) - [style/useThrowOnlyError](https://biomejs.dev/linter/rules/use-throw-only-error/) - [suspicious/noConsole](https://biomejs.dev/linter/rules/no-console/) - [suspicious/noEvolvingTypes](https://biomejs.dev/linter/rules/no-evolving-types/) - [suspicious/noMisplacedAssertion](https://biomejs.dev/linter/rules/no-misplaced-assertion/) - [suspicious/noReactSpecificProps](https://biomejs.dev/linter/rules/no-react-specific-props/) - [suspicious/useErrorMessage](https://biomejs.dev/linter/rules/use-error-message/) - [suspicious/useNumberToFixedDigitsArgument](https://biomejs.dev/linter/rules/use-number-to-fixed-digits-argument/) ##### Deprecated rules - `correctness/noInvalidNewBuiltin` is deprecated. Use [correctness/noInvalidBuiltinInstantiation](https://biomejs.dev/linter/rules/no-invalid-builtin-instantiation/) instead. - `style/useSingleCaseStatement` is deprecated. Use [correctness/noSwitchDeclarations](https://biomejs.dev/linter/rules/no-switch-declarations/) instead. - `suspicious/noConsoleLog` is deprecated. Use [suspicious/noConsole](https://biomejs.dev/linter/rules/no-console/) instead. ##### New features - Implement [css suppression action](biomejs/biome#3278). Contributed by [@​togami2864](https://github.com/togami2864) - Add support for GraphQL linting. Contributed by [@​ematipico](https://github.com/ematipico) - Add [nursery/noCommonJs](https://biomejs.dev/linter/rules/no-common-js/). Contributed by [@​minht11](https://github.com/minht11) - Add [nursery/noDuplicateCustomProperties](https://biomejs.dev/linter/rules/no-duplicate-custom-properties/). Contributed by [@​chansuke](https://github.com/chansuke) - Add [nursery/noEnum](https://biomejs.dev/linter/rules/no-enum/). Contributed by [@​nickfla1](https://github.com/nickfla1) - Add [nursery/noDynamicNamespaceImportAccess](https://biomejs.dev/linter/no-dynamic-namespace-import-access/). Contributed by [@​minht11](https://github.com/minht11) - Add [nursery/noIrregularWhitespace](https://biomejs.dev/linter/rules/no-irregular-whitespace). Contributed by [@​michellocana](https://github.com/michellocana) - Add [nursery/noRestrictedTypes](https://biomejs.dev/linter/no-restricted-types/). Contributed by [@​minht11](https://github.com/minht11) - Add [nursery/noSecrets](https://biomejs.dev/linter/rules/no-secrets/). Contributed by [@​SaadBazaz](https://github.com/SaadBazaz) - Add [nursery/noUselessEscapeInRegex](https://biomejs.dev/linter/rules/no-useless-escape-in-regex/). Contributed by [@​Conaclos](https://github.com/Conaclos) - Add [nursery/noValueAtRule](https://biomejs.dev/linter/rules/no-value-at-rule/). Contributed by [@​rishabh3112](https://github.com/rishabh3112) - Add [nursery/useAriaPropsSupportedByRole](https://biomejs.dev/linter/rules/use-aria-props-supported-by-role/). Contributed by [@​ryo-ebata](https://github.com/ryo-ebata) - Add [nursery/useConsistentMemberAccessibility](https://biomejs.dev/linter/rules/use-consistent-member-accessibility/). Contributed by [@​seitarof](https://github.com/seitarof) - Add [nursery/useStrictMode](https://biomejs.dev/linter/rules/use-strict-mode/). Contributed by [@​ematipico](https://github.com/ematipico) - Add [nursery/useTrimStartEnd](https://biomejs.dev/linter/rules/use-trim-start-end/). Contributed by [@​chansuke](https://github.com/chansuke) - Add [nursery/noIrregularWhitespace](https://biomejs.dev/linter/rules/no-irreguluar-whitespace/). Contributed by [@​DerTimonius](https://github.com/DerTimonius) ##### Enhancements - Rename `nursery/noUnknownSelectorPseudoElement` to `nursery/noUnknownPseudoElement`. Contributed by [@​togami2864](https://github.com/togami2864) - The CSS linter is now enabled by default. Which means that you don't need to opt-in anymore using the configuration file `biome.json`: ```diff { - "css": { - "linter": { - "enabled": true - } - } } ``` Contributed by [@​ematipico](https://github.com/ematipico) - The JavaScript linter recognizes TypeScript 5.5 and 5.6 globals. Contributed by [@​Conaclos](https://github.com/Conaclos) - [noBlankTarget](https://biomejs.dev/linter/rules/no-blank-target/) now supports an array of allowed domains. The following configuration allows `example.com` and `example.org` as blank targets. ```json "linter": { "rules": { "a11y": { "noBlankTarget": { "level": "error", "options": { "allowDomains": ["example.com", "example.org"] } } } } } ``` Contributed by [@​Jayllyz](https://github.com/Jayllyz) - [noConsole](https://biomejs.dev/linter/rules/no-console/) now accepts an option that specifies some allowed calls on `console`. Contributed by [@​Conaclos](https://github.com/Conaclos) - Add an `ignoreNull` option for [noDoubleEquals](https://biomejs.dev/linter/rules/no-double-equals/). By default the rule allows loose comparisons against `null`. The option `ignoreNull` can be set to `false` for reporting loose comparison against `null`. Contributed by [@​peaBerberian](https://github.com/peaBerberian). - [noDuplicateObjectKeys](https://biomejs.dev/linter/rules/no-duplicate-object-keys/) now works for JSON and JSONC files. Contributed by [@​ematipico](https://github.com/ematipico) - [noInvalidUseBeforeDeclaration](https://biomejs.dev/linter/rules/no-invalid-use-before-declaration) now reports direct use of an enum member before its declaration. In the following code, `A` is reported as use before its declaration. ```ts enum E { B = A << 1, A = 1, } ``` Contributed by [@​Conaclos](https://github.com/Conaclos) - [noNodejsModules](https://biomejs.dev/linter/rules/no-nodejs-modules/) now ignores imports of a package which has the same name as a Node.js module. Contributed by [@​Conaclos](https://github.com/Conaclos) - [noNodejsModules](https://biomejs.dev/linter/rules/no-nodejs-modules/) now ignores type-only imports ([#​1674](biomejs/biome#1674)). The rule no longer reports type-only imports such as: ```ts import type assert from "assert"; import type * as assert2 from "assert"; ``` Contributed by [@​Conaclos](https://github.com/Conaclos) - [noRedundantUseStrict](https://biomejs.dev/linter/rules/no-redundant-use-strict/) no longer reports `"use strict"` directives when the `package.json` marks explicitly the file as a script using the field `"type": "commonjs"`. Contributed by [@​ematipico](https://github.com/ematipico) - [noStaticOnlyClass](https://biomejs.dev/linter/rules/no-static-only-class/) no longer reports a class that extends another class ([#​3612](biomejs/biome#3612)). Contributed by [@​errmayank](https://github.com/errmayank) - [noUndeclaredVariables](https://biomejs.dev/linter/rules/no-undeclared-variables/) no longer reports a direct reference to an enum member ([#​2974](biomejs/biome#2974)). In the following code, the `A` reference is no longer reported as an undeclared variable. ```ts enum E { A = 1, B = A << 1, } ``` Contributed by [@​Conaclos](https://github.com/Conaclos) - [noUndeclaredVariables](https://biomejs.dev/linter/rules/no-undeclared-variables/) recognized Svelte 5 runes in Svelte components and svelte files. Svelte 5 introduced runes. The rule now recognizes Svelte 5 runes in files ending with the `.svelte`, `.svelte.js` or `.svelte.ts` extensions. Contributed by [@​Conaclos](https://github.com/Conaclos) - [noUnusedVariables](https://biomejs.dev/linter/rules/no-unused-variables/) now checks TypeScript declaration files. This allows to report a type that is unused because it isn't exported. Global declarations files (declarations files without exports and imports) are still ignored. Contributed by [@​Conaclos](https://github.com/Conaclos) - [useFilenamingConvention](https://biomejs.dev/linter/rules/use-filenaming-convention) now supports [unicase](https://en.wikipedia.org/wiki/Unicase) letters. [unicase](https://en.wikipedia.org/wiki/Unicase) letters have a single case: they are neither uppercase nor lowercase. Biome now accepts filenames in unicase. For example, the filename `안녕하세요` is now accepted. We still reject a name that mixes unicase characters with lowercase or uppercase characters. For example, the filename `A안녕하세요` is rejected. This change also fixes [#​3353](biomejs/biome#3353). Filenames consisting only of numbers are now accepted. Contributed by [@​Conaclos](https://github.com/Conaclos) - [useFilenamingConvention](https://biomejs.dev/linter/rules/use-filenaming-convention) now supports Next.js/Nuxt/Astro dynamic routes ([#​3465](biomejs/biome#3465)). [Next.js](https://nextjs.org/docs/pages/building-your-application/routing/dynamic-routes#catch-all-segments), [SolidStart](https://docs.solidjs.com/solid-start/building-your-application/routing#renaming-index), [Nuxt](https://nuxt.com/docs/guide/directory-structure/server#catch-all-route), and [Astro](https://docs.astro.build/en/guides/routing/#rest-parameters) support dynamic routes such as `[...slug].js` and `[[...slug]].js`. Biome now recognizes this syntax. `slug` must contain only alphanumeric characters. Contributed by [@​Conaclos](https://github.com/Conaclos) - [useExportType](https://biomejs.dev/linter/rules/use-export-type/) no longer reports empty `export` ([#​3535](biomejs/biome#3535)). An empty `export {}` allows you to force TypeScript to consider a file with no imports and exports as an EcmaScript module. While `export type {}` is valid, it is more common to use `export {}`. Users may find it confusing that the linter asks them to convert it to `export type {}`. Also, a bundler should be able to remove `export {}` as well as `export type {}`. So it is not so useful to report `export {}`. Contributed by [@​Conaclos](https://github.com/Conaclos) ##### Bug fixes - [noControlCharactersInRegex](https://www.biomejs.dev/linter/rules/no-control-characters-in-regex) now corretcly handle `\u` escapes in unicode-aware regexes. Previously, the rule didn't consider regex with the `v` flags as unicode-aware regexes. Moreover, `\uhhhh` was not handled in unicode-aware regexes. Contributed by [@​Conaclos](https://github.com/Conaclos) - [noControlCharactersInRegex](https://www.biomejs.dev/linter/rules/no-control-characters-in-regex) now reports control characters and escape sequence of control characters in string regexes. Contributed by [@​Conaclos](https://github.com/Conaclos) - `noExcessiveNestedTestSuites`: fix an edge case where the rule would alert on heavily nested zod schemas. Contributed by [@​dyc3](https://github.com/dyc3) - `noExtraNonNullAssertion` no longer reports a single non-null assertion enclosed in parentheses ([#​3352](biomejs/biome#3352)). Contributed by [@​Conaclos](https://github.com/Conaclos) - [noMultipleSpacesInRegularExpressionLiterals](https://biomejs.dev/linter/rules/no-multiple-spaces-in-regular-expression-literals/) now correctly provides a code fix when Unicode characters are used. Contributed by [@​Conaclos](https://github.com/Conaclos) - [noRedeclare](https://biomejs.dev/linter/rules/no-redeclare/) no longer report redeclartions for lexically scoped function declarations [#​3664](biomejs/biome#3664). In JavaScript strict mode, function declarations are lexically scoped: they cannot be accessed outside the block where they are declared. In non-strict mode, function declarations are hoisted to the top of the enclosing function or global scope. Previously Biome always hoisted function declarations. It now takes into account whether the code is in strict or non strict mode. Contributed by [@​Conaclos](https://github.com/Conaclos) - [noUndeclaredDependencies](https://biomejs.dev/linter/rules/no-undeclared-dependencies/) now ignores self package imports. Given teh following `package.json`: ```json { "name": "my-package", "main": "index.js" } ``` The following import is no longer reported by the rule: ```js import * as mod from "my-package"; ``` Contributed by [@​Conaclos](https://github.com/Conaclos) - Fix \[[#​3149](biomejs/biome#3149)] crashes that occurred when applying the `noUselessFragments` unsafe fixes in certain scenarios. Contributed by [@​unvalley](https://github.com/unvalley) - [noRedeclare](https://biomejs.dev/linter/rules/no-redeclare/) no longer reports a variable named as the function expression where it is declared. Contributed by [@​Conaclos](https://github.com/Conaclos) - `useAdjacentOverloadSignatures` no longer reports a `#private` class member and a public class member that share the same name ([#​3309](biomejs/biome#3309)). The following code is no longer reported: ```js class C { #f() {} g() {} f() {} } ``` Contributed by [@​Conaclos](https://github.com/Conaclos) - [useAltText](https://www.biomejs.dev/linter/rules/use-alt-text) n olonger requests alt text for elements hidden from assistive technologies ([#​3316](biomejs/biome#3316)). Contributed by [@​robintown](https://github.com/robintown) - [useNamingConvention](https://biomejs.dev/linter/rules/use-naming-convention/) now accepts applying custom convention on abstract classes. Contributed by [@​Conaclos](https://github.com/Conaclos) - [useNamingConvention](https://biomejs.dev/linter/rules/use-naming-convention/) no longer suggests an empty fix when a name doesn't match strict Pascal case ([#​3561](biomejs/biome#3561)). Previously the following code led `useNamingConvention` to suggest an empty fix. The rule no longer provides a fix for this case. ```ts type AAb = any ``` Contributed by [@​Conaclos](https://github.com/Conaclos) - [useNamingConvention](https://biomejs.dev/linter/rules/use-naming-convention/) no longer provides fixes for global TypeScript declaration files. Global TypeScript declaration files have no epxorts and no imports. All the declared types are available in all files of the project. Thus, it is not safe to propose renaming only in the declaration file. Contributed by [@​Conaclos](https://github.com/Conaclos) - [useSortedClasses](https://biomejs.dev/linter/rules/use-sorted-classes/) lint error with Template literals ([#​3394](biomejs/biome#3394)). Contributed by [@​hangaoke1](https://github.com/hangaoke1) - [useValidAriaValues](https://biomejs.dev/linter/rules/use-valid-aria-values/) now correctly check property types ([3748](biomejs/biome#3748)). Properties that expect a string now accept arbitrary text. An identifiers can now be made up of any characters except ASCII whitespace. An identifier list can now be separated by any ASCII whitespace. Contributed by [@​Conaclos](https://github.com/Conaclos) ##### Parser ##### Enhancements - The JSON parser now allows comments in `turbo.json` and `jest.config.json`. Contributed by [@​Netail](https://github.com/Netail) and [@​Conaclos](https://github.com/Conaclos) - The JSON parser now allows comments in files with the `.json` extension under the `.vscode` and `.zed` directories. Biome recognizes are well known JSON files that allows comments and/or trailing commas. Previously, Biome did not recognize JSON files under the `.vscode` and the `.zed` directories as JSON files that allow comments. You had to configure Biome to recognize them: ```json { "overrides": [ { "include": ["**/.vscode/*.json", "**/.zed/*.json"], "json": { "parser": { "allowComments": true } } } ] } ``` This override is no longer needed! Note that JSON files under the `.vscode` and the `.zed` directories don't accept trailing commas. Contributed by [@​Conaclos](https://github.com/Conaclos) ##### Bug fixes - The CSS parser now accepts emoji in identifiers ([3627](biomejs/biome#3627)). The following code is now correctly parsed: ```css p { --🥔-color: red; color: var(--🥔-color); } ``` Contributed by [@​Conaclos](https://github.com/Conaclos) - Fix [#​3287](biomejs/biome#3287) nested selectors with pseudo-classes. Contributed by [@​denbezrukov](https://github.com/denbezrukov) - Fix [#​3349](biomejs/biome#3349) allow CSS multiple ampersand support. Contributed by [@​denbezrukov](https://github.com/denbezrukov) ```css .class { && { color: red; } } ``` - Fix [#​3410](biomejs/biome#3410) by correctly parsing break statements containing keywords. ```js out: while (true) { break out; } ``` Contributed by [@​ah-yu](https://github.com/ah-yu) - Fix [#​3464](biomejs/biome#3464) by enabling JSX in `.vue` files that use the `lang='jsx'` or `lang='tsx'` attribute. Contributed by [@​ematipico](https://github.com/ematipico) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43Ny4zIiwidXBkYXRlZEluVmVyIjoiMzguNzcuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: Alexandre Soro <[email protected]> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/110 Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I ran into a bug with JSX expressions for this rule, as seen in #3689. In this PR, we're handling the various ways you can define this attribute with slightly more robustness.
Test Plan
I've added to the
valid.jsxfile for this rule to recreate the bug I ran into. It passes now!