feat(lint): add useConsistentCurlyBraces

[dyc3]

Summary

This PR adds the useConsistentCurlyBraces lint. It doesn't implement any of the options from the eslint rule for simplicity.

This implementation aims to follow the recommendations outlined in the eslint rule: react/jsx-curly-brace-presence

closes #2435

Test Plan

Added snapshot tests

cargo test -p biome_js_analyze use_consistent_curly_braces

[codspeed-hq]

CodSpeed Performance Report

Merging #3182 will degrade performances by 9.36%

_{Comparing dyc3:06-02-feat_lint_add_usejsxcurlybraceconvention_ (ec663b9) with dyc3:06-02-feat_lint_add_usejsxcurlybraceconvention_ (7890fbe)}

Summary

❌ 7 regressions
✅ 101 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	dyc3:06-02-feat_lint_add_usejsxcurlybraceconvention_	dyc3:06-02-feat_lint_add_usejsxcurlybraceconvention_	Change
❌	js_analyzer[css_557271668126329798.js]	15.3 ms	16.6 ms	-7.45%
❌	js_analyzer[index_129807605716630866.js]	32.9 ms	35.6 ms	-7.53%
❌	js_analyzer[lint_11654203871763747189.ts]	25.9 ms	28.4 ms	-8.76%
❌	js_analyzer[parser_8282555732666328882.ts]	53 ms	57.3 ms	-7.45%
❌	js_analyzer[router_14177007973872119684.ts]	15.3 ms	16.8 ms	-9.06%
❌	js_analyzer[statement_17851180443367440905.ts]	47.7 ms	52.6 ms	-9.36%
❌	js_analyzer[typescript_4309201908630379962.ts]	76.2 ms	84 ms	-9.32%

[chansuke]

Great work! Thank you :)

[dyc3]

Hit a small blocker with this merge conflict. Usually other rules getting added causes these merge conflicts, and running just gen-lint usually fixes it, but this time it's throwing cannot find macro rule_category in this scope. Would the easiest fix be to just redo the codegen on a fresh branch?

[ematipico]

@dyc3 declare_rule has been renamed declare_lint_rule. That will fix everything

[Geczy]

when does this get released to production?

404
https://biomejs.dev/linter/rules/use-jsx-curly-brace-convention

[ematipico]

when does this get released to production?

404
https://biomejs.dev/linter/rules/use-jsx-curly-brace-convention

Probably beginning of September. You can use the nightly channel for early releases