Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement useErrorMessage #2978

Merged
merged 2 commits into from
May 25, 2024

Conversation

minht11
Copy link
Contributor

@minht11 minht11 commented May 24, 2024

Summary

Closes #2972
Implement unicorn/error-message

Test Plan

Added snapshots

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis A-Changelog Area: changelog labels May 24, 2024
Copy link

codspeed-hq bot commented May 24, 2024

CodSpeed Performance Report

Merging #2978 will not alter performance

Comparing minht11:feat/useErrorMessage (4758cd7) with main (49f6530)

Summary

✅ 92 untouched benchmarks

@unvalley
Copy link
Member

Implementation looks good to me.

@unvalley unvalley merged commit fec262f into biomejs:main May 25, 2024
13 checks passed
@minht11 minht11 deleted the feat/useErrorMessage branch May 25, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Parser Area: parser A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Implement useErrorMessage - unicorn/error-message
2 participants