Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint/useLiteralKeys): emit correct AST for assignment expressions #269

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

ematipico
Copy link
Member

Summary

Closes #266

Test Plan

Added a CLI test, because that's where it happens.

@ematipico ematipico temporarily deployed to Website deployment September 13, 2023 14:53 — with GitHub Actions Inactive
@github-actions github-actions bot added A-CLI Area: CLI A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Sep 13, 2023
@github-actions github-actions bot added the A-Website Area: website label Sep 13, 2023
@ematipico ematipico temporarily deployed to Website deployment September 13, 2023 14:54 — with GitHub Actions Inactive
@ematipico ematipico changed the title fix(linter): emit correct AST for useLiteralKeys fix(lint/useLiteralKeys): emit correct AST for assignment expressions Sep 13, 2023
@ematipico ematipico merged commit e5e5b62 into main Sep 13, 2023
@ematipico ematipico deleted the fix/use-literal-keys branch September 13, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 complexity/useLiteralKeys emits invalid AST
2 participants