Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css_formatter): Always quote attribute matcher values #1321

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

faultyserver
Copy link
Contributor

Summary

#1285. This PR ensures that all values for an attribute selector are quoted. For example:

[type=text][type="checkbox"] {}

/* becomes */
[type="text"][type="checkbox"] {
}

The quotes are not necessary syntactically, but ensure consistency across the board (and this matches Prettier's output).

Once quote styles are supported, this will also select the appropriate quote character to use, but that is a future situation.

Test Plan

The attribute matching spec test is updated with quoted values.

Copy link

netlify bot commented Dec 23, 2023

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 314a3a6
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/658762134a097500083c1e84
😎 Deploy Preview https://deploy-preview-1321--biomejs.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added A-Formatter Area: formatter L-CSS Language: CSS labels Dec 23, 2023
@faultyserver faultyserver mentioned this pull request Dec 23, 2023
11 tasks
@faultyserver faultyserver merged commit d12e99c into main Dec 24, 2023
18 checks passed
@faultyserver faultyserver deleted the faulty/css-quote-attributes branch December 24, 2023 04:53
@Conaclos Conaclos added the A-Changelog Area: changelog label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Formatter Area: formatter L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants