feat(css_formatter): support for pseudo selectors #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs canceled.
|
denbezrukov
approved these changes
Dec 22, 2023
Comment on lines
+86
to
+92
| :nth-child( | ||
| 2n | ||
| + 1 of li, | ||
|
|
||
| .test | ||
| ) { | ||
| } |
There was a problem hiding this comment.
This one is not expected! Thanks for catching it.
Comment on lines
+34
to
+43
| :-webkit-any(i, p, :link, span:focus) { | ||
| } | ||
| :-webkit-any( | ||
| i, | ||
| p, | ||
| :link, | ||
|
|
||
| span:focus | ||
| ) { | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
This is the result of using the join_with_* builders right now, because they try to respect the newlines from the input source. It comes up in a few places where we want to just ignore the input and always output single newlines (like selector lists) or keep them flat (like this case).
I think I'll do a pass on all of these and fix them in one go in a follow up PR today.
Comment on lines
+39
to
+51
| :lang(de, fr) { | ||
| } | ||
| :lang( | ||
| de, | ||
|
|
||
| fr | ||
| ) { | ||
| } | ||
|
|
||
| :lang(de) { | ||
| } | ||
| :lang(de, fr, en, es, hi, pt) { | ||
| } |
There was a problem hiding this comment.
Same as the above here, once the selector list stops trying to respect the newlines from the input, this should flatten out and match Prettier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1285. This implements formatting support for (seemingly) all of the pseudo selector styles that the parser currently supports.
I'd like to deduplicate some of the work, specifically around how a lot of nodes implement the same parenthesize-and-indent pattern:
The consistency definitely feels like it should be managed in one place, but the difficulty is that some of the nodes use
CssIdentifierwhile others have a specificSyntaxTokeninstead, so merging them isn't super straightforward. I might just make the block content re-usable? It's also a one time cost to write it all out, so maybe trying to unify them isn't super worth it.Test Plan
Added a bunch of different spec tests to cover the various permutations of pseudo selectors.
Of note: the selector lists currently use
join_with_*, which tries to respect newlines in the input source, but for CSS formatting we don't actually want to do that in most cases (all cases except rule list and declaration list). I'm going to leave that as something to tackle later, but it will be needed for Prettier compatibility in the future.