feat(css_formatter): support for attribute selectors [#1285] #1286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1285. This implements attribute selectors and all of the sub-nodes for it.
Two notes:
$=
attribute matchers, like[href$='.com']
. This gets parsed ashref$
being an identifier, then the rest becomes bogus. All of the other operators work as expected, though.quoteStyle
option once that gets added later on.Test Plan
Added a bunch of spec tests to roughly match prettier, sans the
$=
matcher