Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rebrand the homepage(colors and hero-brand) #1009

Merged
merged 33 commits into from
Dec 7, 2023

Conversation

vasucp1207
Copy link
Member

@vasucp1207 vasucp1207 commented Dec 2, 2023

Summary

  • Some global styles are broken for the markdown code tab.
  • Need some improvement in responsiveness.
  • Need feedback for the Community section(I think it's a bit empty for now).

cc @ematipico

Test Plan

@github-actions github-actions bot added the A-Website Area: website label Dec 2, 2023
@vasucp1207 vasucp1207 marked this pull request as draft December 2, 2023 00:24
@ematipico
Copy link
Member

Can you rebase the website with main so we can check the preview?

@github-actions github-actions bot added the A-CLI Area: CLI label Dec 2, 2023
@ematipico
Copy link
Member

Would you like to remove the linter tab or just the benchmarks part?

For the time being, yes please.

Can you upload a InteiiJ plugin screenshot here?

We can do that later in a different PR. What do I need to upload?

The community section uses the autogenerated Contributors.astro so these are random avatars.

We have a script that applies the randomness. I suppose you want to do something similar:

const creditsPeopleLists = document.querySelectorAll(".credits-people-list");
for (const list of creditsPeopleLists) {
const items = list.querySelectorAll("li");
for (const li of randomShuffle(Array.from(items))) {
list.appendChild(li);
}
}

@vasucp1207
Copy link
Member Author

Sure, you can upload screenshot in resources.

@ematipico
Copy link
Member

Sure, you can upload screenshot in resources.

We can do that later :)

What's missing? I am very exited to start merging things!

@vasucp1207
Copy link
Member Author

Sure, you can upload screenshot in resources.

We can do that later :)

What's missing? I am very exited to start merging things!

Refactor code according to required changes and also apply some media queries, check now.

@vasucp1207 vasucp1207 marked this pull request as ready for review December 6, 2023 21:50
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for starting things! Here's some advice on how to do better PRs and help us to make god reviews, and some feedback for this PR:

  • in general, in open source, it's better to do small and localized PRs
  • my suggestion is to break down this PR in smaller ones, for example:
    • new logo and colours
    • contributor component
    • the performance component
  • we are adding all new assets and they are not used anywhere and I can't understand why; we should add only those images that we use. No need to create a new folder, we can replace the ones the currently have (or delete them)
  • you have a typo in folder, srcipts instead of scripts. Also, we already have a folder for that, called frontend-scripts
  • please remove the images we don't use;

Maybe, as a starting point, we can make this PR as a colour change and new logo. What do you think?

const updateProgress = () => {
const elapsed = Date.now() - startTime;
const newProgress = elapsed / 1000;
console.log(newProgress, "p");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

Comment on lines 9 to 12
margin-top: 20px;
width: 50px;
margin-left: 10px;
font-size: 15px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I am not a fan fan of px, unless they are really needed. For example, font sizes can use rem or em. Can we use rem or em instead?

.bar {
height: 100%;
transition: width 0.1s ease-in;
background-color: #60a5fa;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For colours and sizes, we should use starlight colours, or create our own CSS variables and use them here.

--sl-community-link: #ffffff;
}

.hero.astro-jbfsktt5 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These styles that have strange letters are auto-generated, which means that they might change in the future. We can't override the styles like this.

@vasucp1207
Copy link
Member Author

@ematipico, thanks for the guidance, now this PR only targets the colors changes, hero-brand update and cards component. I will open separate PRs for the other components.

@vasucp1207 vasucp1207 changed the title Rebrand the homepage feat: Rebrand the homepage(colors and hero-brand) Dec 7, 2023
@vasucp1207 vasucp1207 requested a review from ematipico December 7, 2023 16:29
@ematipico
Copy link
Member

ematipico commented Dec 7, 2023

Unfortunately, the light blue doesn't work when the light theme is enabled. We get a lot of issues with contrast not being enough:

Screenshot 2023-12-07 at 16 50 33

Maybe we should just use the black 🤔

@vasucp1207
Copy link
Member Author

Can you check the new version?

@ematipico
Copy link
Member

Still nothing, but we can figure it out later :) I think for now we can merge it and continue with other works. Thank you!

@ematipico ematipico merged commit acdbe45 into biomejs:website-v2 Dec 7, 2023
4 checks passed
@Conaclos Conaclos added the A-Changelog Area: changelog label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Website Area: website L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants