fix(js_formatter): format hook with 3 arguments

biomejs · Nov 4, 2024 · 0eade7a · 0eade7a
1 parent ec46f37
commit 0eade7a
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 2 deletions.
diff --git a/crates/biome_js_formatter/src/js/expressions/call_arguments.rs b/crates/biome_js_formatter/src/js/expressions/call_arguments.rs
@@ -1205,14 +1205,21 @@ fn is_multiline_template_only_args(arguments: &JsCallArguments) -> bool {
 /// useMemo(() => {}, [])
 /// ```
 fn is_react_hook_with_deps_array(arguments: &JsCallArguments, comments: &JsComments) -> bool {
+    if arguments.args().len() > 3 || arguments.args().len() < 2 {
+        return false;
+    };
+
     use AnyJsExpression::*;
     let mut args = arguments.args().iter();
+    if arguments.args().len() == 3 {
+        args.next();
+    }
 
     match (args.next(), args.next()) {
         (
             Some(Ok(AnyJsCallArgument::AnyJsExpression(JsArrowFunctionExpression(callback)))),
             Some(Ok(AnyJsCallArgument::AnyJsExpression(JsArrayExpression(deps)))),
-        ) if arguments.args().len() == 2 => {
+        ) => {
             if comments.has_comments(callback.syntax()) || comments.has_comments(deps.syntax()) {
                 return false;
             }

diff --git a/crates/biome_js_formatter/tests/specs/prettier/js/do/call-arguments.js b/crates/biome_js_formatter/tests/specs/prettier/js/do/call-arguments.js
@@ -39,3 +39,7 @@ expect(
     bar;
   }
 ).toThrow(ReferenceError);
+
+useImperativeHandle(ref, () => {
+  return;
+}, []);
diff --git a/crates/biome_js_formatter/tests/specs/prettier/js/do/call-arguments.js.prettier-snap b/crates/biome_js_formatter/tests/specs/prettier/js/do/call-arguments.js.prettier-snap
@@ -31,3 +31,7 @@ expect(
     bar;
   },
 ).toThrow(ReferenceError);
+
+useImperativeHandle(ref, () => {
+  return;
+}, []);
diff --git a/crates/biome_js_formatter/tests/specs/prettier/js/do/call-arguments.js.snap b/crates/biome_js_formatter/tests/specs/prettier/js/do/call-arguments.js.snap
@@ -47,6 +47,10 @@ expect(
   }
 ).toThrow(ReferenceError);
 
+useImperativeHandle(ref, () => {
+  return;
+}, []);
+
 ```
 
 
@@ -104,7 +108,7 @@ expect(
    var bar = "foo";
    bar;
  };
-@@ -28,6 +40,6 @@
+@@ -28,9 +40,9 @@
      () => {
        var bar = "foo";
      };
@@ -114,6 +118,9 @@ expect(
 +bar;
 +}
 +).toThrow(ReferenceError)
+
+ useImperativeHandle(ref, () => {
+   return;
 ```
 
 # Output
@@ -164,6 +171,10 @@ expect(
 bar;
 }
 ).toThrow(ReferenceError)
+
+useImperativeHandle(ref, () => {
+  return;
+}, []);
 ```
 
 # Errors
@@ -394,6 +405,7 @@ call-arguments.js:40:3 parse ━━━━━━━━━━━━━━━━━
   > 41 │ ).toThrow(ReferenceError);
        │ ^^^^^^^^^^^^^^^^^^^^^^^^^
     42 │ 
+    43 │ useImperativeHandle(ref, () => {
   
   i Expected a statement here.
   
@@ -404,6 +416,7 @@ call-arguments.js:40:3 parse ━━━━━━━━━━━━━━━━━
   > 41 │ ).toThrow(ReferenceError);
        │ ^^^^^^^^^^^^^^^^^^^^^^^^^
     42 │ 
+    43 │ useImperativeHandle(ref, () => {
   
 
 ```