Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emit of explicit keys #492

Merged
merged 5 commits into from
Jan 20, 2025
Merged

Fix emit of explicit keys #492

merged 5 commits into from
Jan 20, 2025

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Jan 20, 2025

  • fix emit of explicit keys when indented:
    fixed:
      ? explicit key
      : value
    previously:
      ? explicit key
    : value   # this was not indented

Also:

Closes #471 (likely fixed in #489)
Closes #259

@biojppm biojppm changed the title Fix emit of literal Fix emit of literal/folded keys Jan 20, 2025
@biojppm biojppm force-pushed the fix/emit_empty_key branch from 475ed74 to d2b536a Compare January 20, 2025 12:17
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (d4457b9) to head (6291900).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   97.30%   97.32%   +0.01%     
==========================================
  Files          34       34              
  Lines       11322    11325       +3     
==========================================
+ Hits        11017    11022       +5     
+ Misses        305      303       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biojppm biojppm force-pushed the fix/emit_empty_key branch from d2b536a to 6291900 Compare January 20, 2025 15:03
@biojppm biojppm changed the title Fix emit of literal/folded keys Fix emit of explicit keys Jan 20, 2025
@biojppm biojppm merged commit c7b792d into master Jan 20, 2025
253 of 254 checks passed
@biojppm biojppm deleted the fix/emit_empty_key branch January 20, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

val_is_null() bug crash parsing explicit keys/empty values
1 participant