-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] accept tabs as tokens after : and - #211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 97.00% 97.06% +0.06%
==========================================
Files 77 77
Lines 16672 16664 -8
==========================================
+ Hits 16172 16175 +3
+ Misses 500 489 -11
Continue to review full report at Codecov.
|
This feature is too costly for the benefits it offers. It costs somewhere between 10-15% in throughput/cpu time because of the added branching. Here is a benchmark for parsing a file which is not even token-heavy. First, before the feature:
Now, with the feature:
|
d7abb96
to
1cedc69
Compare
No description provided.