Add support for permanova #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses part of #30 |
wasade
reviewed
Jan 28, 2023
There was a problem hiding this comment.
Parsing TSV in c++ does not look fun...
Is there any chance a some unit tests mirroring the skbio PERMANOVA tests, and additionally some tests on the TSV parsing? Former are verified against the original implementation and the latter is important as edge cases could effect the statistics
Yes, we should add some unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssu can now compute PERMANOVA.
Needs access to a TSV file.
The data is stored in the hdf5 file as a list of stats elements.