Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code inversion for ambiguities solving in fetch? #108

Closed
cotillau opened this issue Aug 16, 2021 · 1 comment
Closed

Code inversion for ambiguities solving in fetch? #108

cotillau opened this issue Aug 16, 2021 · 1 comment

Comments

@cotillau
Copy link

In functions fetch_samples_from_obserations and fetch_samples_from_samples, there may be an inversion in the code when resolving ambiguities.

    if resolve_ambiguities == 'merge':
        tab = redbiom.fetch._ambiguity_keep_most_reads(tab, map_)
    elif resolve_ambiguities == 'most-reads':
        tab = redbiom.fetch._ambiguity_merge(tab, map_)
@wasade
Copy link
Member

wasade commented Aug 16, 2021

Can confirm -- good spot, thank you!

@wasade wasade closed this as completed in fd44d23 Oct 1, 2021
wasade added a commit to wasade/redbiom that referenced this issue Oct 21, 2021
antgonza added a commit that referenced this issue Oct 21, 2021
* TST: bulk get index test

* Batch index requests

* A little cleanup on debug items

* Additional comments

* sty

* Update redbiom/admin.py

Co-authored-by: Antonio Gonzalez <[email protected]>

* BUG: fixes #108, thanks @cotillau!

* VER: actually bump it, partially resolves #107, thanks @BenKaehler

* tentative py3738 support

* update actions

* update actions

* update actions

* update actions

* update actions

* update actions

* update actions

* update actions

* update actions

* update actions

* update actions

* update actions

* update actions

* BUG: fixes #93

* BUG: fixes #92

* remove unhelpful print

* Bump version

* Force json (#113)

* TST: sample id content type bug

* MAINT: fix issue where samples with .raw as a suffix were triggering unexpected returns

* Don't suffix twice

* Adjsut to account for force of json

* Address @antgonza's comments

* use the right variable name

* Verify data appear count

* Verify data appear count

Co-authored-by: Antonio Gonzalez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants