added admin delete reason #560
Conversation
| @@ -14,6 +16,31 @@ def _check_account_is_admin(self, admin_email): | |||
|
|
|||
| return False if count == 0 else True | |||
|
|
|||
| def _row_to_removal(self, r): | |||
| return RemovalQueueRequest(r['id'], r['account_id'], r['email'], | |||
There was a problem hiding this comment.
In case this is called from a subclass, this is a little more defensive:
| return RemovalQueueRequest(r['id'], r['account_id'], r['email'], | |
| return self.__class__(r['id'], r['account_id'], r['email'], |
| @@ -17,5 +17,6 @@ CREATE TABLE ag.account_removal_log ( | |||
| -- user makes multiple requests. | |||
| disposition DISPOSITION_TYPE, | |||
| requested_on timestamptz, | |||
| reviewed_on timestamptz default current_timestamp | |||
| reviewed_on timestamptz default current_timestamp, | |||
There was a problem hiding this comment.
This is patching a patch, rather than a new patch?
There was a problem hiding this comment.
Ah, yeah I should make a new patch, better practice
|
Sorry about that, all is good. |
|
@ayobi Can you please rename |
|
@ayobi When you have a moment, can you please merge |
|
Should be merged now @cassidysymons 👍 |
|
@ayobi Thanks for the quick turnaround on the interested user scrubbing, but can you break that into a separate branch (and pull request)? I already have the account deletion staging changes up on our staging server and I'd prefer to not expand scope here. |
|
Absolute, will do 👍 |
ayobi
force-pushed
the
master-overhaul
branch
from
e8735cd to
cf5f46c
Compare
Added delete_reason column and adjusted params allowing a delete reason to be attached from the admin when an account has been deleted.