Limit Unfinished Vioscreen Sessions #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks. Fixing unit tests before merging. Long-term, it would be good to adjust the unit tests to create new Vioscreen registry entries & sessions rather than depending on stable ones in the database, but that's not something I really want to tackle at the moment. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR limits the
VioscreenSessionRepo.get_unfinished_sessions()function to the past 30 days, relative either to the creation date (for criteria 1 within the function) or the last modified date (relative to criteria 2/3).The impact on staging is that the number of unfinished sessions drops from 4344 to 3. Based on this substantial change, I'm going to defer on adding any
sleepcalls between sessions until/unless Viocare requests further changes.Note: This PR is relative to overhaul, as I'd like to observe it running on staging for 48 hours before pushing an equivalent change to master.