Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete account #423

Merged
merged 17 commits into from
Mar 9, 2022
Merged

Delete account #423

merged 17 commits into from
Mar 9, 2022

Conversation

wasade
Copy link
Member

@wasade wasade commented Mar 8, 2022

Implements an admin endpoint to delete an account if safe, scrubbing otherwise, such that non-identifiable details are retained

@wasade
Copy link
Member Author

wasade commented Mar 8, 2022

I believe this is now good for review

microsetta_private_api/admin/admin_impl.py Outdated Show resolved Hide resolved
if has_samples:
# if we have samples, we need to scrub survey / source
# free text
print(surveys)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print(surveys)
print(surveys)
Suggested change
print(surveys)

@wasade
Copy link
Member Author

wasade commented Mar 8, 2022

@cassidysymons suggested checking with how authrocket will be handled

@cassidysymons noted connection to interested users, and cleaning up that table -- an issue will be created as that is out of scope here.

TODO: add remaining docstrings

@wasade
Copy link
Member Author

wasade commented Mar 9, 2022

Adding a note on authrocket to the interface template

@wasade wasade merged commit 2efa875 into biocore:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant