Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fallback to default on best_match #365

Merged
merged 4 commits into from
Aug 16, 2021

Conversation

wasade
Copy link
Member

@wasade wasade commented Aug 13, 2021

...avoid a possible None for language

Copy link
Collaborator

@dhakim87 dhakim87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely approve of setting default on best_match and tests for invalid tags, but

I don't understand why normalize is necessary. All calls are coming in through microsetta-interface, which sets language tag to whatever we specify. Where the heck did a tag with the wrong casing come from???

@wasade
Copy link
Member Author

wasade commented Aug 13, 2021

Worth having the normalize to be defensive or should it be dropped?

Copy link
Collaborator

@dhakim87 dhakim87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather remove the normalize if we can track down who is sending up "en_us", "en_us" is used as a key sent to babel so being passed up may mean we show the wrong language consent form or something because we forgot to do the lookup.

@wasade wasade merged commit fb12b25 into biocore:master Aug 16, 2021
@wasade wasade deleted the default_best_match branch December 13, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants