-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype Vioscreen Hotfix -- !Probably Don't Merge This Ever! #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of the standard build_db, and a server_config change to set a path
wasade
reviewed
Feb 19, 2021
status_map[all_wrong_flags[k]] += 1 | ||
|
||
print("\n\n-------------------------------------------------\n\n") | ||
print("SUMMARY OF THINGS THAT ARE WRONG:") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there an upperuppercase?
wasade
reviewed
Jun 8, 2021
wasade
reviewed
Jun 8, 2021
@@ -405,7 +426,6 @@ def migrate_74(TRN): | |||
(r[0], r[1], r[2], r[3])) | |||
TRN.execute() | |||
|
|||
@staticmethod | |||
def migrate_77(TRN): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
def migrate_77(TRN): | |
@staticmethod | |
def migrate_77(TRN): |
Tentative 0082 update
wasade
reviewed
Jun 25, 2021
wasade
reviewed
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run vioscreen_hotfix.py to see what the patch will do. Remove the rollback if you want to be able to run it multiple times and see statuses move towards all successful. If we do go forward with it, just need to ensure 76 is listed in the migration_support list of patches to run.
Specify path to your vioscreen_status.tsv file in server_config.json.