report overhaul phase 2 #325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassidysymons
requested changes
Nov 26, 2024
Comment on lines
+1375
to
+1413
| if (diversityInSampleValue == highestDiversityScore) { | ||
| const angle = scale(diversityInSampleValue); | ||
| drawIndicatorLine(angle, radius * 0.97, radius * 0.46, -46); | ||
| } | ||
|
|
||
| if (diversityInSampleValue > lowestDiversityScore && diversityInSampleValue <= 2.99) { | ||
| const angle = scale(diversityInSampleValue); | ||
| drawIndicatorLine(angle, radius * 0.75, radius * 0.45, 13); | ||
| } | ||
|
|
||
| if (diversityInSampleValue >= 3.0 && diversityInSampleValue <= 3.99) { | ||
| const angle = scale(diversityInSampleValue); | ||
| drawIndicatorLine(angle, radius * 0.65, radius * 0.30, 3); | ||
| } | ||
|
|
||
| if (diversityInSampleValue >= 4.0 && diversityInSampleValue <= 4.99) { | ||
| const angle = scale(diversityInSampleValue); | ||
| drawIndicatorLine(angle, radius * 0.30, radius * 0.35, 8); | ||
| } | ||
|
|
||
| if (diversityInSampleValue >= 5.0 && diversityInSampleValue <= 5.99) { | ||
| const angle = scale(diversityInSampleValue); | ||
| drawIndicatorLine(angle, radius * 0.10, radius * 0.35, -30); | ||
| } | ||
|
|
||
| if (diversityInSampleValue >= 6.0 && diversityInSampleValue <= 6.49) { | ||
| const angle = scale(diversityInSampleValue); | ||
| drawIndicatorLine(angle, radius * 0.25, radius * 0.55, 5); | ||
| } | ||
|
|
||
| if (diversityInSampleValue >= 6.5 && diversityInSampleValue <= 6.99) { | ||
| const angle = scale(diversityInSampleValue); | ||
| drawIndicatorLine(angle, radius * 0.25, radius * 0.45, 5); | ||
| } | ||
|
|
||
| if (diversityInSampleValue >= 7.0 && diversityInSampleValue < highestDiversityScore) { | ||
| const angle = scale(diversityInSampleValue); | ||
| drawIndicatorLine(angle, radius * 0.45, radius * 0.25, -35); | ||
| } |
There was a problem hiding this comment.
Now that the line for the diversity score is being drawn via d3 rather than trying to position a nested SVG, can you please condense all of these conditional statements? We know what the angle is, so shouldn't it just be a matter of drawing a line from the desired inner radius to the desired outer radius? If that's not the case, please explain the issue that requires these conditionals.
There was a problem hiding this comment.
I'll send an email with explanation and screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For phase 2, we are implementing the new diversity score graph in the diversity tab.