Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin flask-babel #278

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Pin flask-babel #278

merged 1 commit into from
Mar 28, 2023

Conversation

cassidysymons
Copy link
Collaborator

@wasade And this one as well, please.

@@ -5,5 +5,5 @@ pycryptodome
redis-py
redis
pytest
flask-babel
flask-babel=2.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why that vs "flask-babel < 3.0.0" used in private api?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't recall the specific reason I had done it this way, but we install it via pip in API and conda in Interface. I seem to recall that was the root of a minor difference that caused the corresponding difference in how I'd pinned them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's :shipit: if passing then

@cassidysymons cassidysymons merged commit 91864b0 into master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants