Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed requested by Japanese collaborators #259

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Conversation

cassidysymons
Copy link
Collaborator

This PR corresponds to biocore/microsetta-private-api#482 and includes the interface changes necessary to support that.

In addition:

  1. Removes US phone validation as a default rule on submit_interest.jinja2. Now, phone is required, but it will only validate format when a user selects United States as the country. In the future, per-country phone validation would be ideal, but since it's the tertiary mode of contact in this context, it's unimportant.
  2. Updates a few strings in messages.po for ja_JP

@wasade wasade merged commit c60318c into master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants