Enhance pl #87
Merged
Enhance pl #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Querying by project is now availabe on the per summary page.
|
Thanks!! Seems reasonable, but will hold off on merge as it's a WIP |
|
@charles-cowart i need to merge this as we merged the upstream PR for -private-api. Were you planning on adding unittests and if so, could htat be done in a separate PR? |
|
@wasade Will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wasade Requesting summaries for a project is now available on the per-sample summaries page. (Now renamed sample summaries).
This is still a work in progress. It needs flake8 and unittests. I want to also let the user get both a warning when over 1000 barcodes were requested, but also get the first 1000 samples. That will require a little tweaking. Should be ready before Monday.