Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in importing leading-zero zip codes #86

Merged
merged 1 commit into from
Oct 19, 2021
Merged

fix bug in importing leading-zero zip codes #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions microsetta_admin/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,10 +763,12 @@ def return_error(msg):
fulfillment_hold_msg = request.form.get('fulfillment_hold_msg')

try:
# NB: import everything as a string so that zip codes beginning with
# zero (e.g., 06710) don't get silently cast to numbers
if file.filename.endswith('xls'):
addresses_df = pd.read_excel(file)
addresses_df = pd.read_excel(file, dtype=str)
elif file.filename.endswith('xlsx'):
addresses_df = pd.read_excel(file, engine='openpyxl')
addresses_df = pd.read_excel(file, engine='openpyxl', dtype=str)
else:
raise ValueError(f"Unrecognized extension on putative excel "
f"filename: {file.filename}")
Expand Down