add KATHAROseq samples to SIFs. #128
Conversation
|
I don't think the defaults are the same as these are positive not negative controls. And, it's necessary that the values like cell count are part of metadata |
@wasade ty! I'll send Gail an email in the morning and show her what we're populating the blanks with, the columns in the SIFs, and she can let me know what to fill in. |
Pull Request Test Coverage Report for Build 8024854693Details
💛 - Coveralls |
from '..._blanks.tsv' to '..._wetlab.tsv', per request.
|
Thanks! And please remember that the individual KatharoSeq controls samples will differ from each other, and that those differences are necessary to interpret the data. |
|
Just to update this conversation, I emailed Gail and MacKenzie regarding this issue and she's going to provide information today and Monday to address it. |
|
Great, thanks!
… On Feb 23, 2024, at 12:44 PM, Charles Cowart ***@***.***> wrote:
Just to update this conversation, I emailed Gail and MacKenzie regarding this issue and she's going to provide information today and Monday to address this issue.
—
Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/biocore/mg-scripts/pull/128*issuecomment-1961965746__;Iw!!Mih3wA!D6Jkf526RUTGAUlEo1xQ1ETXo6FED3w99xCIMvhesJgKHLH2nDK7_akQGE0xDMP8x7IH_2D8t1AVDPcfrSlwO6ZAhNwsUhphs_ILRw$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AADTZMQLZAFRWBKLYXRI4O3YVD5STAVCNFSM6AAAAABDWC3YLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRHE3DKNZUGY__;!!Mih3wA!D6Jkf526RUTGAUlEo1xQ1ETXo6FED3w99xCIMvhesJgKHLH2nDK7_akQGE0xDMP8x7IH_2D8t1AVDPcfrSlwO6ZAhNwsUhp5xY33bg$>.
You are receiving this because you were mentioned.
|
Samples in pre-prep files beginning w/KATHARO will be added to SIFs just like BLANKs are. Based on a comparison between the columns in the pre-prep files and the SIFs, I don't see any overlap where additional column values should be populated using the pre-prep file. Hence, the KATHARO rows will be populated w/the same defaults that BLANKs are.
No tests were affected, and no tests were broken due to this change. That being said, it's relatively straightforward and trivial and I think we can dispense with an additional test for now.