Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: update reindex_axis for pandas 0.25.1 #282

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

ebolyen
Copy link
Member

@ebolyen ebolyen commented Oct 11, 2019

Hey @mortonjt, we were updating QIIME 2's environment, and we saw gneiss was still using the older pandas API which has since been removed. Fortunately, it's a very simple fix.

(I also fixed the assertEquals deprecation warnings while I was at it).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.703% when pulling d1196a7 on ebolyen:pandas-0.25.1 into 20cbcaa on biocore:master.

@ebolyen
Copy link
Member Author

ebolyen commented Oct 11, 2019

Oh no. We've been here before: #280

@mortonjt
Copy link
Collaborator

ouch - not sure how I missed that. These changes look good @ebolyen . Let me close #280. Thanks!

@mortonjt mortonjt merged commit fdf8fa2 into biocore:master Oct 11, 2019
@thermokarst
Copy link

Thanks @mortonjt! Will you be able to cut a new conda package for this? We will need it for q2-gneiss, in order to keep it up-to-date in the next release of QIIME 2 (scheduled for the end of the month).

@mortonjt
Copy link
Collaborator

ok. A release has been cut and is now on pypi

Regarding conda - I've pushed a PR here to upgrade the version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants