Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading numpy version #278

Merged
merged 14 commits into from
Jul 1, 2019
Merged

Upgrading numpy version #278

merged 14 commits into from
Jul 1, 2019

Conversation

mortonjt
Copy link
Collaborator

This will allow us to upgrade the skbio version

@mortonjt
Copy link
Collaborator Author

ugh .. we are getting a bunch of outdated errors from bokeh + pandas nonsense.

@mortonjt
Copy link
Collaborator Author

ok, turns out that both matplotlib and bokeh haven been updated.

The plots look fine, but the order of which the objects have been plotted has changed.

image

image

@mortonjt
Copy link
Collaborator Author

Tests should be passing now. We will want to deprecate all visualizations in gneiss in the near future. The heatmap dendrograms have been pushed to calour and the radial trees have been pushed to empress.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.703% when pulling 187f536 on mortonjt:numpy-upgrade into e615c4c on biocore:master.

@mortonjt
Copy link
Collaborator Author

mortonjt commented Jul 1, 2019

Alright. Merging.

@mortonjt mortonjt merged commit 14986dc into biocore:master Jul 1, 2019
mortonjt added a commit to mortonjt/gneiss that referenced this pull request Jul 1, 2019
* ENH: upgrade numpy

* DOC: updating numpy docstring

* ENH: upgrading version number

* BLD: setting matplotlib backend to agg

* trimming down ci requirements

* adding back in flake8 and pep8

* adding pip back in

* DOC: raw strings

* flake8

* looks like bokeh flipped the ordering.  weird

* matplotlib tick labels swapped

* py36

* flake8

* forgot import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants