-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proportion plots #234
Proportion plots #234
Conversation
|
||
Parameters | ||
---------- | ||
table : pd.DataFrame |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you concerned about requiring dense matrices for the table data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope
The API looks pretty good to me. For the plots, I have some suggestions to make them clearer:
The more customizable the plots are, the better people can get what they want, and the more likely they are to use the plots. |
Thanks for taking a look over it Luke! The user actually already has full control to modify the underlying plots -- this function is returning a full matplotlib figure. But maybe it would be useful to have some clear cut examples in the documentation about how to modify these labels. What do you think? |
Since the comments have been addressed, and this PR has been outstanding for a while, I'm going to go ahead and merge this in so that we can start integrating this functionality into the q2-gneiss plugin. |
This will summarize the mean proportions for each of the balances
You can use this module as follows
@wasade @cuttlefishh do you have any thoughts on the current API? Do you think it is intuitive, or should this be simplified?