Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional abbreviated parameters for the standalone CLI; add some more context to the README #481

Merged
merged 6 commits into from
Feb 3, 2021

Conversation

fedarko
Copy link
Collaborator

@fedarko fedarko commented Feb 3, 2021

This makes the CLI a bit easier to use if you're in a hurry, since potentially generating a visualization can be as short as:

$ empress tree-plot -t tree.nwk -o viz

I also updated the README a bit to document this, and to make it a bit fancier in general. (One of the changes is consistently using hyphens in filenames for some of the early examples. I didn't modify the QIIME 2 tutorial since the filenames there [IIRC] were designed to be consistent with Q2's tutorial files, some of which have underscores instead of hyphens.)

Not all of the parameters in the standalone CLI have short equivalents (e.g. --filter-extra-samples will still have to be written out in full). I think this is reasonable, since arguably part of the rationale for many of these parameters is requiring the user to acknowledge e.g. "yes I recognize that I am asking the program to filter out certain samples right now".

@fedarko fedarko requested a review from gibsramen February 3, 2021 04:23
Copy link
Collaborator

@gibsramen gibsramen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@gibsramen gibsramen merged commit 5d14e07 into biocore:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants