PERF: Speed-up taxonomic string preprocessing #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string operations are vectorized which makes processing the EMP taxonomy strings go from 45 seconds to ~1.5 seconds.
|
The following artifacts were built for this PR: empire-biplot.qzv, empire.qzv, empress-tree.qzv |
fedarko
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
Thanks @ElDeveloper, this looks great! I have one minor question but aside from that this should be good to merge. Having all of these speedups in will be really exciting :) 🦔
|
Looks good to me! Thanks so much @ElDeveloper :) |
|
Thanks @fedarko! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string operations are vectorized which makes processing the EMP
taxonomy strings go from 45 seconds to ~1.5 seconds.