Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draw legends for each barplot layer #299

Closed
fedarko opened this issue Aug 5, 2020 · 0 comments · Fixed by #340
Closed

Draw legends for each barplot layer #299

fedarko opened this issue Aug 5, 2020 · 0 comments · Fixed by #340
Assignees
@fedarko
Labels
barplots feature request
Milestone
1.1 Release

Comments

@fedarko
Copy link
Collaborator

fedarko commented Aug 5, 2020

Continuation of #201.
@fedarko fedarko self-assigned this Aug 5, 2020
@ElDeveloper ElDeveloper added this to the Second Beta Release milestone Aug 5, 2020
@fedarko fedarko mentioned this issue Aug 6, 2020
Open
4 tasks
@fedarko fedarko mentioned this issue Aug 15, 2020
Closed
fedarko added a commit to fedarko/empress that referenced this issue Aug 15, 2020
@fedarko
MNT: simplify Legend code (rm separate "keys")
e81ad34 
This rips out "node/tip/clade key" legend stuff. (The SVG exporting
code might need updating, not sure.)

This makes the code simpler, and should make doing biocore#299 easier
fedarko added a commit to fedarko/empress that referenced this issue Aug 17, 2020
@fedarko
ENH: show (categorical) barplot layer legends!
88a733d 
The UI is very unpolished, but this does close biocore#299.
fedarko added a commit to fedarko/empress that referenced this issue Aug 19, 2020
@fedarko
DOC: update README re: biocore#299 (barplot legends)
dfc8b1d 
Also added a section on continuous values in the barplot legend
@fedarko fedarko mentioned this issue Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedarko fedarko

Labels
barplots feature request
Projects
None yet
Milestone
1.1 Release
Development

Successfully merging a pull request may close this issue.

Refactor and test legend code; show barplot legends fedarko/empress
2 participants
@ElDeveloper @fedarko