Update: Metabuli 1.0.8 #51030
Update: Metabuli 1.0.8 #51030
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces updates to the Changes
Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🪛 yamllint
🔇 Additional comments (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
recipes/metabuli/meta.yaml (1)
Line range hint
44-45: Consider updating the package summary.The PR objectives mention a new
extractmodule in Metabuli 1.0.8, which allows users to extract reads classified under a specific taxon at any rank. Consider updating the package summary to reflect this new feature.You might want to modify the summary as follows:
- summary: "Metabuli: specific and sensitive metagenomic classification via joint analysis of DNA and amino acid" + summary: "Metabuli: specific and sensitive metagenomic classification via joint analysis of DNA and amino acid, with read extraction capabilities"🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/metabuli/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/metabuli/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (2)
recipes/metabuli/meta.yaml (2)
1-1: Version update looks good.The version has been correctly updated to 1.0.8, which aligns with the PR objectives for the new Metabuli release.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
2-2: Verify the SHA256 checksum.The SHA256 checksum has been updated, which is expected for a new version. However, it's crucial to ensure this checksum is correct for the Metabuli 1.0.8 release.
Please run the following script to verify the SHA256 checksum:
recipes/metabuli/meta.yaml
Outdated
|
|
||
| package: | ||
| name: metabuli | ||
| version: {{ version }} | ||
|
|
||
| build: | ||
| number: 2 | ||
| number: 1 |
There was a problem hiding this comment.
Reset build number to 0.
When updating to a new version, it's standard practice to reset the build number to 0. The current change decreases it from 2 to 1, but it should be set to 0 for the new 1.0.8 version.
Please apply the following change:
- number: 1
+ number: 0📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| number: 1 | |
| number: 0 |
|
@BiocondaBot please add label |
Metabuli v1.0.8
extractmodule: It extracts reads classified under a specific taxon at any ranks. It can be used after runningclassify.Metabuli v1.0.7
Metabuli became faster than v1.0.6
Dataset
Windows: ~8.3 times faster
--max-ram: 32--threads: 8MacOS: ~1.7 times faster
--max-ram: 32--threads: 8Linux: ~1.3 times faster
--max-ram: 128--threads: 32--threads: 64Metabuli v1.0.6
Windows OS is supported
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.Summary by CodeRabbit
New Features
metabulipackage to version 1.0.8, providing users with the latest enhancements and improvements.Bug Fixes