Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanopolish bioconda update #14218

Merged
merged 3 commits into from
Mar 29, 2019
Merged

Conversation

paultsw
Copy link
Contributor

@paultsw paultsw commented Mar 28, 2019

ℹ️
Bioconda has finished the GCC7 migration. If you are dealing with C/C++ or Python package it can be that you need to rebuild other dependent packages. Bioconda utils - update-pinning will assist you with that. If you have any questions please use issue 13578.


  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

@paultsw
Copy link
Contributor Author

paultsw commented Mar 28, 2019

@bgruening to be honest I'm actually not sure w/r/t the gcc exception for OS X. I'm updating the recipe primarily because we've just tagged a new release of nanopolish (v0.11.1) and wanted to be sure the bioconda release was as up-to-date as possible. As I only have access to a linux machine, I'm in favour of otherwise keeping the recipe as-is, aside from the sha256 hash and the bumped version. What's your opinion?

@bgruening
Copy link
Member

Can we just try and if it does not work revert?

@bgruening
Copy link
Member

In general, I'm fine with that. We should just remember to fix that at some point. Feel free to merge.

@paultsw
Copy link
Contributor Author

paultsw commented Mar 28, 2019

Okay, I'll make a note to fix this for another day. (I don't have the ability to merge, though.)

@PertuyF
Copy link
Contributor

PertuyF commented Mar 29, 2019

@bgruening The exception is because gcc is not supported for OSX using the new compilers, and nanopolish does not build with clang. See #14014 and #14016 for details.

Using a selector on libgcc in run dependencies should be fine I guess.

@paultsw merging for you as I pass by

@PertuyF PertuyF merged commit e954369 into bioconda:master Mar 29, 2019
tfursten added a commit that referenced this pull request Mar 31, 2019
* add mtsv recipe

trigger rebuild

Update build.sh

Update conda_build_config.yaml

Update meta.yaml

change python pinning

* update adVNTR to 1.3.0 (#14209)

* add adVNTR

* fix linux error for adVNTR

* add numpy to adVNTR requirements

* add numpy include dirs for cythonize

* Update advntr to 1.1.0

* Update advntr to 1.1.0

* update advntr to 1.1.1

* update adVNTR to 1.2.0

* update sha256 for adVNTR-1.2.0

* fix build script for adVNTR-1.2.0

* fix adVNTR-1.2.0

* update advntr and its requirements

* update advntr -- pysam and htslib versions

* skip py37

* force python version to be less than 3.7

* fix noarch problem

* exclude python 3.7

* fix a typo

* try another approach to exclude py37

* Update meta.yaml

* Bump toulligqc (#14221)

* Lumpy-express dependencies added (#14215)

Added hexdump-, sambamba- and samblaster dependencies under run and increased the build number to 4.

* Update clever-toolkit and distribute a shared library with kmc (#14224)

* Update clever-toolkit and distribute a shared library with kmc

* skip KMC on OSX, it uses gcc-specific headers

* Nanopolish bioconda update (#14218)

* bump nanopolish recipe to version 0.11.1

* bump nanopolish version to 0.11.1; update build number

* remove libgcc

@paultsw do you think its possible to remove the gcc execption for OSX already?

* Irida uploader (#14118)

:information_source:
Bioconda has finished the [GCC7 migration](#13578). If you are dealing with C/C++ or Python package it can be that you need to rebuild other dependent packages. [Bioconda utils - update-pinning](https://bioconda.github.io/updating.html#updating-recipes-for-a-pinning-change) will assist you with that. If you have any questions please use [issue 13578](#13578).

----------------

* [x] I have read the [guidelines for bioconda recipes](https://bioconda.github.io/guidelines.html).
* [x] This PR adds a new recipe.
* [x] AFAIK, this recipe **is directly relevant to the biological sciences** (otherwise, please submit to the more general purpose [conda-forge channel](https://conda-forge.org/docs/)).
* [ ] This PR updates an existing recipe.
* [ ] This PR does something else (explain below).

* change requirement versions to match v2.1.2 and bumped version (#14231)

* Update duphold to 0.1.2 (#14232)

* Add recipe for Augustus 3.3.2 (#14219)

* Add recipe for Augustus 3.3.2

* Add recipe for GapFiller 2.1.1. (#14234)

* Bumped GATK4 version (#14222)

:information_source:
Bioconda has finished the [GCC7 migration](#13578). If you are dealing with C/C++ or Python package it can be that you need to rebuild other dependent packages. [Bioconda utils - update-pinning](https://bioconda.github.io/updating.html#updating-recipes-for-a-pinning-change) will assist you with that. If you have any questions please use [issue 13578](#13578).

----------------

* [X] I have read the [guidelines for bioconda recipes](https://bioconda.github.io/guidelines.html).
* [] This PR adds a new recipe.
* [X] AFAIK, this recipe **is directly relevant to the biological sciences** (otherwise, please submit to the more general purpose [conda-forge channel](https://conda-forge.org/docs/)).
* [X] This PR updates an existing recipe.
* [ ] This PR does something else (explain below).

* add orca to nanocomp, make noarch (#14228)

add mtsv recipe

trigger rebuild

Update build.sh

Update conda_build_config.yaml

Update meta.yaml

change python pinning

add maintainer

fix copy of mtsv-db-build

fix binary list

pip install

pip install

remove setuptools

rm imports

test

test

setuptools

pinning

remove mtsv-db test

bump build

* change build

* move binaries to prefix/bin

* force recheck
@PertuyF
Copy link
Contributor

PertuyF commented Mar 31, 2019

@bgruening looks like new packages are available in the channel, but CircleCi noticed that upload failed for Linux.
Is it normal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants