Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

22.11 #34

Merged
merged 6 commits into from
Nov 16, 2022
Merged

22.11 #34

merged 6 commits into from
Nov 16, 2022

Conversation

HadleyKing
Copy link
Contributor

No description provided.

	new file:   .vscode/settings.json
	modified:   portalusers/settings.py
Prefix are created by UI and submitted to the public bco_api.

Changes to be committed:
	modified:   admin_only/db.sqlite3.dev
	modified:   core/urls.py
	modified:   core/views.py
Changes to be committed:
	modified:   core/views.py
Changes to be committed:
	modified:   .vscode/settings.json
	modified:   core/apps.py
	modified:   core/migrations/0001_initial.py
	modified:   core/migrations/0002_prefixes.py
	modified:   core/migrations/0003_auto_20220330_2122.py
	modified:   core/migrations/0004_auto_20220716_1651.py
	modified:   core/models.py
	modified:   core/serializers.py
	modified:   core/tests/test_models.py
	modified:   core/urls.py
	modified:   core/views.py
	modified:   docs/source/conf.py
	modified:   manage.py
	modified:   portalusers/asgi.py
	modified:   portalusers/settings.py
	modified:   portalusers/urls.py
	modified:   portalusers/utils.py
	modified:   portalusers/wsgi.py
	modified:   simple_api_info_fill.py
@gitguardian
Copy link

gitguardian bot commented Nov 16, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Django Secret Key 749bd72 portalusers/settings.py View secret
- Django Secret Key 749bd72 portalusers/settings.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@HadleyKing HadleyKing merged commit 5375359 into main Nov 16, 2022
@HadleyKing HadleyKing deleted the 22.11 branch November 16, 2022 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant