Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL fetch for BCO Published Objects #42

Merged
merged 30 commits into from
Dec 13, 2021
Merged

Conversation

syntheticgio
Copy link
Collaborator

@syntheticgio syntheticgio commented Nov 15, 2021

Supports the call:

/<PREFIX>_<BCO_NAME>/<BCO VERSION>

Closes #37

@syntheticgio syntheticgio linked an issue Nov 15, 2021 that may be closed by this pull request
@syntheticgio
Copy link
Collaborator Author

Working example: http://localhost:8000/BCO_000010/1.0 So the format /<BCO_NAME>/ works (does not specifically worry about the prefix, although may want to worry about that later depending on how we store these).

@syntheticgio syntheticgio marked this pull request as ready for review December 5, 2021 18:45
@syntheticgio
Copy link
Collaborator Author

I think this is ready to test @HadleyKing - looks to be working for me (if version is requested, going to follow up w/o version to get the most recent). I had played around with splitting the prefix from the bco name - but it seems like the bco name includes the prefix and so doesn't need to have it split out?

@syntheticgio syntheticgio changed the title Fix URL fetch for BCO Published Objects WIP: Fix URL fetch for BCO Published Objects Dec 5, 2021
This reverts commit eced191, reversing
changes made to 10e5b32.
@syntheticgio
Copy link
Collaborator Author

syntheticgio commented Dec 5, 2021

Looks like we will need to do something more like http://localhost:8000/bcos/BCO_000010/1.0 @HadleyKing - it appears having a regex for the first item in the URL doesn't work unless there are things following it. Not sure if it is just django limitation or if there is something special you need to do; but prefixing the BCO ID fixes the issue. I'd propose:

http://localhost:8000/bcos/BCO_000010
http://localhost:8000/bcos/BCO_000010/1.0

As examples which get you the basic functionality.

EDIT: This might be wrong actually; I'm not sure why we keep getting the authentication issue with the first example above even with the bcos namespace added. Still looking into it.

EDIT2: Disregard, there was a conflicting URL endpoint for draft BCOs that was capturing the calls

@syntheticgio syntheticgio changed the title WIP: Fix URL fetch for BCO Published Objects Draft: Fix URL fetch for BCO Published Objects Dec 5, 2021
@syntheticgio syntheticgio marked this pull request as draft December 5, 2021 19:38
@syntheticgio syntheticgio marked this pull request as ready for review December 13, 2021 19:29
@syntheticgio syntheticgio changed the title Draft: Fix URL fetch for BCO Published Objects Fix URL fetch for BCO Published Objects Dec 13, 2021
@syntheticgio
Copy link
Collaborator Author

Ready for review @HadleyKing

@HadleyKing HadleyKing merged commit 3b064ce into 2.0.0 Dec 13, 2021
@syntheticgio syntheticgio deleted the fix-get-published-bcos branch December 26, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object ID Versioning
2 participants