-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execution Domain #50
Comments
env_parameters should a simple dictionary of a list of dictionaries. Should avoid saying "Environmental parameters" --> should be environment variables apply #50
env_parameters should a simple dictionary of a list of dictionaries. Should avoid saying "Environmental parameters" --> should be environment variables apply #50
@HadleyKing in regards to 98c53dc resolving extra-validation-items-execution-domain.md:
It looks like the idea was to change this: "env_parameters": [{
"key": "HOSTTYPE",
"value" : "x86_64-linux"
}] to this: "environment_variables": {
"HOSTTYPE": "x86_64-linux",
"EDITOR": "vim",
"FOO_BAR": "baz_quox"
} |
@corburn |
I was also trying to implement some sort of
|
environment_variables schema: "environment_variables": {
"type": "object",
"description": "Environmental parameters that are useful to configure the execution environment on the target platform.",
"additionalProperties": false,
"patternProperties": {
"^[a-zA-Z_]+[a-zA-Z0-9_]*$": {
"type": "string"
}
}
} The regex is based on the following:
script and script_access_typeI would drop https://tools.ietf.org/html/rfc8089 "script": {
"$ref": "#/definitions/uri"
} |
… MD.2 env_parameters should a simple dictionary of a list of dictionaries. Should avoid saying "Environmental parameters" --> should be environment variables apply #50
Issues from execution-domain
URI values require regex
(maybe it is not necessary here)
In general, this domain needs more refinement
domain_prerequisites.name should also be renamed
regex for domain_prerequisites.url
Should avoid saying "Environmental parameters" --> should be environment variables
The text was updated successfully, but these errors were encountered: